Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(switch): Update switch checked styling on foundation init #3147

Merged
merged 3 commits into from
Jul 19, 2018

Conversation

rlfriedman
Copy link
Contributor

This fixes an issue where Firefox would remember the state of the hidden input element on refresh which could result in a mismatch between switch styling and actual checked state.

@codecov-io
Copy link

Codecov Report

Merging #3147 into feat/switch-update will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           feat/switch-update    #3147      +/-   ##
======================================================
+ Coverage               98.32%   98.32%   +<.01%     
======================================================
  Files                     104      104              
  Lines                    4538     4540       +2     
  Branches                  587      587              
======================================================
+ Hits                     4462     4464       +2     
  Misses                     76       76
Impacted Files Coverage Δ
packages/mdc-switch/foundation.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6e37a5...19ededa. Read the comment docs.

Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on all browsers I could on OS X and Windows. In some I was able to test by navigating to a new page then going back, rather than refreshing. Looks like it's working everywhere.

@rlfriedman rlfriedman merged commit 293bdba into feat/switch-update Jul 19, 2018
@rlfriedman rlfriedman deleted the fix/switch-firefox-refresh branch July 19, 2018 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants