feat(drawer): Improved navigation drawer #3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts/material-components-web into feat/navigation-drawer
…vigation drawer (#2912)
chore: water feat/navigation-drawer branch w/ master
…t/navigation-drawer
Codecov Report
@@ Coverage Diff @@
## master #3417 +/- ##
========================================
- Coverage 98.39% 98.3% -0.1%
========================================
Files 123 119 -4
Lines 5185 5012 -173
Branches 640 612 -28
========================================
- Hits 5102 4927 -175
- Misses 83 85 +2
Continue to review full report at Codecov.
|
|
🤖 Beep boop! Screenshot test report 🚦20 screenshots changed from |
kfranqueiro
approved these changes
Aug 24, 2018
|
🤖 Beep boop! Screenshot test report 🚦20 screenshots changed from |
kfranqueiro
suggested changes
Aug 24, 2018
kfranqueiro
approved these changes
Aug 24, 2018
|
🤖 Beep boop! Screenshot test report 🚦20 screenshots changed from |
|
🤖 Beep boop! Screenshot test report 🚦20 screenshots changed from |
|
🤖 Beep boop! Screenshot test report 🚦20 screenshots changed from |
This was referenced Oct 5, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MDCDrawer(RemovedMDCPersistentDrawer&MDCTemporaryDrawer).BREAKING CHANGE: Drawer variants have new DOM structure, mixins, and JS. MDCPersistentDrawer and MDCTemporaryDrawer components are replaced with a single MDCDrawer component which supports both.