Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(drawer): New sass mixin to set z-index #3453

Merged
merged 3 commits into from
Aug 28, 2018
Merged

feat(drawer): New sass mixin to set z-index #3453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa682db
feat(drawer): New sass mixin to set z-index
abhiomkar Aug 28, 2018
9325626
Merge branch 'master' into feat/drawer/zindex
abhiomkar Aug 28, 2018
a4afc5b
Merge branch 'master' into feat/drawer/zindex
williamernest Aug 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/mdc-drawer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,7 @@ Mixin | Description
`mdc-drawer-item-corner-radius($radius)` | Sets the corner border radius of the drawer list item.
`mdc-drawer-activated-overlay-color($color)` | Sets the overlay color of the activated drawer list item.
`mdc-drawer-scrim-fill-color($color)` | Sets the fill color of `mdc-drawer-scrim`.
`mdc-drawer-z-index($value)` | Sets the z index of drawer. Drawer stays on top of top app bar except for clipped variant of drawer.

## Accessibility

Expand Down
4 changes: 4 additions & 0 deletions packages/mdc-drawer/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,3 +118,7 @@
@include mdc-theme-prop(background-color, $value);
}
}

@mixin mdc-drawer-z-index($value) {
z-index: $value;
}
2 changes: 1 addition & 1 deletion packages/mdc-drawer/common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
@include mdc-drawer-item-activated-icon-ink-color($mdc-drawer-item-activated-ink-color);
@include mdc-drawer-item-activated-text-ink-color($mdc-drawer-item-activated-ink-color);
@include mdc-drawer-item-corner-radius(4px);
@include mdc-drawer-z-index($mdc-drawer-z-index);

display: flex;
flex-direction: column;
Expand All @@ -53,7 +54,6 @@
border-right-width: 1px;
border-right-style: solid;
overflow: hidden;
z-index: $mdc-drawer-z-index;

@include mdc-rtl {
border-right-width: 0;
Expand Down