Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infrastructure): Fix master diff failures on Travis CI #3598

Merged
merged 26 commits into from Sep 21, 2018

Conversation

acdvorak
Copy link
Contributor

@acdvorak acdvorak commented Sep 20, 2018

What it does

  • Fixes Screenshot test CI task hanging/killed while comparing against master #3555:
    • Shards master image diffing into 50 parallel comparisons at a time instead of comparing all 541 images at once
  • Reduces startup time by ~1 minute:
    • Prefetches image files in parallel instead of sequentially
    • Removes unnecessary URL prefetching (e.g., HTML files)
  • Tries to prevent Travis CI job logs from getting truncated too early (e.g., job #766.5):
    • Adds sleep 5 to after_script in .travis.yml (see this GitHub issue)

How to test

  1. Create a PR that modifies golden.json
  2. The Travis CI job should pass, and its log output should have something like this near the bottom:
    Comparing 541 screenshots to master
    
    [+ 12,500ms] Comparing screenshots 1–50...
    [+  5,997ms] Comparing screenshots 51–100...
    

Example output

Before:

https://travis-ci.com/material-components/material-components-web/jobs/145553262

image

After:

https://travis-ci.com/material-components/material-components-web/jobs/147092934

image

@codecov-io
Copy link

codecov-io commented Sep 20, 2018

Codecov Report

Merging #3598 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3598   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files         120      120           
  Lines        5182     5182           
  Branches      645      645           
=======================================
  Hits         5101     5101           
  Misses         81       81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b6d86b...3cc082a. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

4 screenshots changed from master on commit 723aeb4:

Details

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

4 screenshots changed from master on commit 6bc09ca:

Details

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

4 screenshots changed from master on commit d45889c:

Details

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

4 screenshots changed from master on commit 1326da4:

Details

@mdc-web-bot
Copy link
Collaborator

All 541 screenshot tests passed for commit ddc6050 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 541 screenshot tests passed for commit 9a42b9e vs. master! 💯🎉

@codecov-io
Copy link

codecov-io commented Sep 21, 2018

Codecov Report

Merging #3598 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3598   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files         120      120           
  Lines        5182     5182           
  Branches      645      645           
=======================================
  Hits         5101     5101           
  Misses         81       81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b6d86b...d66ae4a. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 541 screenshot tests passed for commit 3cc082a vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 541 screenshot tests passed for commit 925b568 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 541 screenshot tests passed for commit 608afdd vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 541 screenshot tests passed for commit d66ae4a vs. master! 💯🎉

@acdvorak acdvorak changed the title chore(infrastructure): Fix master diffing failure on Travis CI chore(infrastructure): Fix master diff failures on Travis CI Sep 21, 2018
@acdvorak acdvorak merged commit bbaaf77 into master Sep 21, 2018
@acdvorak acdvorak deleted the chore/infra/master-failure branch September 21, 2018 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants