fix(text-field): Send client position to line ripple for touch events #4084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All 655 screenshot tests passed for commit 0757e68 vs. |
kfranqueiro
reviewed
Nov 14, 2018
| target: { | ||
| getBoundingClientRect: () => { | ||
| return {}; | ||
| const mockTouchStartEvent = { |
There was a problem hiding this comment.
Should we update the verify call to expect a specific value passed to setLineRippleTransformOrigin in order to better test this fix?
Codecov Report
@@ Coverage Diff @@
## master #4084 +/- ##
==========================================
+ Coverage 98.67% 98.67% +<.01%
==========================================
Files 126 126
Lines 5601 5603 +2
Branches 746 747 +1
==========================================
+ Hits 5527 5529 +2
Misses 74 74
Continue to review full report at Codecov.
|
|
All 663 screenshot tests passed for commit 48ecc5e vs. |
kfranqueiro
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3643