Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Sync package lock w/ npm install #4183

Merged
merged 3 commits into from Dec 14, 2018
Merged

Conversation

kfranqueiro
Copy link
Contributor

Although greenkeeper tries to update package-lock itself, its updates always seem to cause noise against what an actual local npm i does.

@codecov-io
Copy link

codecov-io commented Dec 14, 2018

Codecov Report

Merging #4183 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4183   +/-   ##
======================================
  Coverage    98.5%   98.5%           
======================================
  Files         127     127           
  Lines        5629    5629           
  Branches      747     747           
======================================
  Hits         5545    5545           
  Misses         84      84

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30da021...db3c794. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 746 screenshot tests passed for commit be10a33 vs. master! 💯🎉

Copy link
Contributor

@acdvorak acdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Ken!

@acdvorak acdvorak added this to the v0.43.0 milestone Dec 14, 2018
@mdc-web-bot
Copy link
Collaborator

All 750 screenshot tests passed for commit db3c794 vs. master! 💯🎉

@kfranqueiro kfranqueiro merged commit a487783 into master Dec 14, 2018
@kfranqueiro kfranqueiro deleted the chore/package-lock branch December 14, 2018 20:39
adrianschmidt pushed a commit to Lundalogik/material-components-web that referenced this pull request Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants