Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update package dependencies / package-locks #4191

Merged
merged 5 commits into from Dec 17, 2018

Conversation

kfranqueiro
Copy link
Contributor

I happened to need to nuke my packages/*/node_modules before releasing today, and noticed that in the process, some package-lock files changed. This in turn led me to canvas for issues in our package-locks.

What I found / what this PR fixes:

  • mdc-list doesn't need a package-lock
  • mdc-snackbar had some outdated dependencies (probably due to it being worked on prior to our last release), which caused npm to want to create a package-lock when it doesn't need one
  • mdc-dialog and mdc-drawer's package-locks only need to reference their third-party dependencies

Note that I'm running npm 6.5.0; it's possible that some of these changes (in particular the changes to mdc-dialog and mdc-drawer) have to do with npm updates, but it's also possible they were simply the result of cleaning out packages/*/node_modules.

@codecov-io
Copy link

codecov-io commented Dec 17, 2018

Codecov Report

Merging #4191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4191   +/-   ##
======================================
  Coverage    98.5%   98.5%           
======================================
  Files         127     127           
  Lines        5629    5629           
  Branches      747     747           
======================================
  Hits         5545    5545           
  Misses         84      84

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe0357d...f79bc80. Read the comment docs.

Copy link
Contributor

@acdvorak acdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdc-web-bot
Copy link
Collaborator

All 754 screenshot tests passed for commit f79bc80 vs. master! 💯🎉

@kfranqueiro kfranqueiro merged commit 33b1633 into master Dec 17, 2018
@kfranqueiro kfranqueiro deleted the chore/package-lock-42 branch December 17, 2018 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants