Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(menu-surface): Convert JS to TypeScript #4273

Merged
merged 52 commits into from
Feb 5, 2019
Merged

feat(menu-surface): Convert JS to TypeScript #4273

merged 52 commits into from
Feb 5, 2019

Commits on Jan 19, 2019

  1. chore(menu-surface): Convert JS to TypeScript 

    Refs #4225
    @acdvorak
    acdvorak committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    6324518 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Merge branch 'feat/typescript' into feat/typescript--menu-surface

    @acdvorak
    acdvorak committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    6b9bdf0 View commit details
    Browse the repository at this point in the history

  2. WIP: Remove MDCMenuSurface prefix from type names; remove `readonly… 

    …` from properties
    @acdvorak
    acdvorak committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    f8a687a View commit details
    Browse the repository at this point in the history

  3. WIP: Simplify types; replace string props with number for top/bottom/… 

    …left/right
    @acdvorak
    acdvorak committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    07fff99 View commit details
    Browse the repository at this point in the history

  4. WIP: Replace indexable types on MenuPosition with keyof

    @acdvorak
    acdvorak committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    a0843b1 View commit details
    Browse the repository at this point in the history

  5. WIP: Consolidate width/height properties into MenuSize objects

    @acdvorak
    acdvorak committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    7e3e6fe View commit details
    Browse the repository at this point in the history

  6. WIP: Rename MenuSize to MenuDimensions

    @acdvorak
    acdvorak committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    1538325 View commit details
    Browse the repository at this point in the history

  7. WIP: Remove obsolete TODOs

    @acdvorak
    acdvorak committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    913f607 View commit details
    Browse the repository at this point in the history

  8. WIP: Remove unnecessary JSDoc annotation

    @acdvorak
    acdvorak committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    947b90a View commit details
    Browse the repository at this point in the history

  9. WIP: Relocate type annotation

    @acdvorak
    acdvorak committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    6f3045d View commit details
    Browse the repository at this point in the history

  10. WIP: Remove stray empty comment

    @acdvorak
    acdvorak committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    f55703f View commit details
    Browse the repository at this point in the history

  11. WIP: Move MenuPosition and MenuDimensions defs from adapter.ts … 

    …to `constants.ts`
    @acdvorak
    acdvorak committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    ee56995 View commit details
    Browse the repository at this point in the history

  12. fix(infrastructure): add strict: true to tsconfig

    Matt Goo committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    ec3b469 View commit details
    Browse the repository at this point in the history

  13. fix: add strict: true to tsconfi

    Matt Goo committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    96c0514 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2019

  1. WIP: Fix linter error

    @acdvorak
    acdvorak committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    e3c3d50 View commit details
    Browse the repository at this point in the history

  2. WIP: Update focusable element types to HTMLElement | SVGElement

    @acdvorak
    acdvorak committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    b95fcfa View commit details
    Browse the repository at this point in the history

  3. WIP: Strong typing for getTransformPropertyName() return value

    @acdvorak
    acdvorak committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    5bf6e27 View commit details
    Browse the repository at this point in the history

  4. WIP: Style

    @acdvorak
    acdvorak committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    0f0525d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feat/typescript--menu-surface' of github.com:material-c… 

    …omponents/material-components-web into feat/typescript--menu-surface
    @acdvorak
    acdvorak committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    83429aa View commit details
    Browse the repository at this point in the history

  6. fix: add tsconfig and update packages

    Matt Goo committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    e704163 View commit details
    Browse the repository at this point in the history

  7. Update foundation.ts

    Matt Goo committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    09aae61 View commit details
    Browse the repository at this point in the history

  8. Update foundation.ts

    Matt Goo committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    fda0f28 View commit details
    Browse the repository at this point in the history

  9. fix: update closest from HTMLElement to Element

    Matt Goo committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    5075a05 View commit details
    Browse the repository at this point in the history

  10. WIP: Fix tslint errors

    @acdvorak
    acdvorak committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    1811646 View commit details
    Browse the repository at this point in the history

  11. fix: remove dups of strict=true

    Matt Goo committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    06bb41a View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'origin/fix/tsconfigupdate' into feat/ty… 

    …pescript--menu-surface
    @acdvorak
    acdvorak committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    b8ec011 View commit details
    Browse the repository at this point in the history

  13. WIP: Fix strict mode errors

    @acdvorak
    acdvorak committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    82eb81e View commit details
    Browse the repository at this point in the history

  14. WIP: Replace most HTMLElement types with Element

    @acdvorak
    acdvorak committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    54a86ae View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2019

  1. WIP: Add MenuDistance type with all properties required

    @acdvorak
    acdvorak committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    583b87d View commit details
    Browse the repository at this point in the history

  2. WIP: Replace Array.forEach() with for...of

    @acdvorak
    acdvorak committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    f71d734 View commit details
    Browse the repository at this point in the history

  3. WIP: Use Partial<MenuDistance> instead of MenuPosition

    @acdvorak
    acdvorak committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    920470d View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/feat/typescript' into feat/types… 

    …cript--menu-surface
    @acdvorak
    acdvorak committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    0d9b8a8 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/feat/typescript' into feat/types… 

    …cript--menu-surface
    @acdvorak
    acdvorak committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    5288593 View commit details
    Browse the repository at this point in the history

  6. WIP: Remove file-level tslint:disable comments

    @acdvorak
    acdvorak committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    ab6d979 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2019

  1. WIP: Use SpecificEventListener

    @acdvorak
    acdvorak committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    7f043d5 View commit details
    Browse the repository at this point in the history

  2. WIP: Fix JSDoc syntax for @see

    @acdvorak
    acdvorak committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    964932d View commit details
    Browse the repository at this point in the history

  3. WIP: Initialize member variables with inline values

    @acdvorak
    acdvorak committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    69d1c19 View commit details
    Browse the repository at this point in the history

  4. WIP: Add comments to members with definite assignment operators (!)

    @acdvorak
    acdvorak committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    6d54f74 View commit details
    Browse the repository at this point in the history

  5. WIP: Revert removal of /index from JS import paths

    @acdvorak
    acdvorak committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    f976600 View commit details
    Browse the repository at this point in the history

  6. WIP: Fix comments in foundation and test

    @acdvorak
    acdvorak committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    ec8d68c View commit details
    Browse the repository at this point in the history

  7. WIP: Increase foundation test coverage from 91% to 99% 

    100.00% Statements (`238/238`)
 99.22% Branches (`128/129`)
100.00% Functions (`58/58`)
100.00% Lines (`224/224`)
    @acdvorak
    acdvorak committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    c2db556 View commit details
    Browse the repository at this point in the history

  8. WIP: Improve component test coverage

    @acdvorak
    acdvorak committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    9452569 View commit details
    Browse the repository at this point in the history

  9. WIP: Increase component test coverage to 100%

    @acdvorak
    acdvorak committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    63845ba View commit details
    Browse the repository at this point in the history

  10. WIP: Clean up debugging code

    @acdvorak
    acdvorak committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    16eb9a7 View commit details
    Browse the repository at this point in the history

  11. WIP: Dummy commit

    @acdvorak
    acdvorak committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    e264819 View commit details
    Browse the repository at this point in the history

  12. Revert "WIP: Dummy commit" 

    This reverts commit e264819.
    @acdvorak
    acdvorak committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    f00a4aa View commit details
    Browse the repository at this point in the history

  13. WIP: Rename .js to .ts in README

    @acdvorak
    acdvorak committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    56b75ac View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2019

  1. WIP: Move Menu* interface defs from constants.ts to new `types.ts… 

    …` file
    @acdvorak
    acdvorak committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    d45afea View commit details
    Browse the repository at this point in the history

  2. WIP: Update Menu* interfaces to point to types.ts in README

    @acdvorak
    acdvorak committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    9c76326 View commit details
    Browse the repository at this point in the history

  3. WIP: Change MenuPosition to Partial<MenuDistance> in MDCMenu's RE… 

    …ADME and component JS
    @acdvorak
    acdvorak committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    b964b75 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. WIP: Fix typo

    @acdvorak
    acdvorak committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    3fee18d View commit details
    Browse the repository at this point in the history

  2. WIP: Change null to empty string to be consistent with PR #4351

    @acdvorak
    acdvorak committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    86cfdad View commit details
    Browse the repository at this point in the history