Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text-field): Set char counter text not to wrap #4423

Merged
merged 2 commits into from
Feb 20, 2019
Merged

fix(text-field): Set char counter text not to wrap #4423

merged 2 commits into from
Feb 20, 2019

Conversation

abhiomkar
Copy link
Contributor

No description provided.

kfranqueiro
kfranqueiro approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, I'm going to guess we didn't run into this originally because we only added the spaces for RTL later.

@mdc-web-bot
Copy link
Collaborator

All 624 screenshot tests passed for commit 9137d6d vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 624 screenshot tests passed for commit 4e91962 vs. master! 💯🎉

@abhiomkar abhiomkar merged commit 9b7dce7 into master Feb 20, 2019
@abhiomkar abhiomkar deleted the fix/textfield_charcounter_nowrap branch February 20, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfranqueiro kfranqueiro kfranqueiro approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abhiomkar @mdc-web-bot @kfranqueiro @googlebot