fix(menu-surface): Fix anchorElement initialization #4462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4462 +/- ##
==========================================
- Coverage 99.05% 99.05% -0.01%
==========================================
Files 130 130
Lines 6237 6235 -2
Branches 811 811
==========================================
- Hits 6178 6176 -2
Misses 58 58
Partials 1 1
Continue to review full report at Codecov.
|
|
All 627 screenshot tests passed for commit af1615d vs. |
acdvorak
approved these changes
Feb 28, 2019
|
All 627 screenshot tests passed for commit 6d83014 vs. |
|
All 627 screenshot tests passed for commit 0e62876 vs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Menu Surface was converted to TypeScript, its
anchorElementfield was initialized tonull. This caused a regression, because any proper setup that occurred ininitialSyncWithDOMwas being steamrolled by thisnullinitialization, because that occurs inconstructoraftersuperis called.