Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(segmented-button): Added foundation business logic #6198

Merged
merged 15 commits into from Jul 14, 2020
Merged

feat(segmented-button): Added foundation business logic #6198

merged 15 commits into from Jul 14, 2020

Commits on Jul 14, 2020

  1. feat: add functionality to segment/foundation 

    implement segment/foundation without accessibility
    @gschrag
    gschrag committed Jul 14, 2020
    Copy the full SHA
    9e0c05d View commit details
    Browse the repository at this point in the history

  2. feat: add accessibility to segment 

    add aria-checked and aria-pressed manipulation for accessibility
    @gschrag
    gschrag committed Jul 14, 2020
    Copy the full SHA
    99d9238 View commit details
    Browse the repository at this point in the history

  3. feat: add functionality to segmented-button foundation 

    implemented segmented-button foundation
    @gschrag
    gschrag committed Jul 14, 2020
    Copy the full SHA
    0ba4763 View commit details
    Browse the repository at this point in the history

  4. chore: fix method name and file reference 

    improve name of isSingleSelect and use correct reference for @material/base
    @gschrag
    gschrag committed Jul 14, 2020
    Copy the full SHA
    e63d326 View commit details
    Browse the repository at this point in the history

  5. refactor: change modularity of aria manipulation 

    pull aria manipulation into helper function to clean and simplify code
    @gschrag
    gschrag committed Jul 14, 2020
    Copy the full SHA
    8dbe614 View commit details
    Browse the repository at this point in the history

  6. test: add unit tests 

    add unit test outlines for segmented-button foundation
    @gschrag
    gschrag committed Jul 14, 2020
    Copy the full SHA
    d99d9c4 View commit details
    Browse the repository at this point in the history

  7. test: add segmented-button foundation unit tests 

    test segmented-button foundation business logic
    @gschrag
    gschrag committed Jul 14, 2020
    Copy the full SHA
    8aff203 View commit details
    Browse the repository at this point in the history

  8. refactor: improve unit test descriptions 

    wrap related tests in a describe block
    @gschrag
    gschrag committed Jul 14, 2020
    Copy the full SHA
    e3ca9c3 View commit details
    Browse the repository at this point in the history

  9. refactor: move singleSelect unselect logic to segment 

    child segment does not unselect self if singleSelect, so parent
segmented-button does not need to check this
    @gschrag
    gschrag committed Jul 14, 2020
    Copy the full SHA
    fc01ba9 View commit details
    Browse the repository at this point in the history

  10. test: remove test of singleSelect segmented-button handling segment u… 

    …nselect

tested functionality is now in segment foundation
    @gschrag
    gschrag committed Jul 14, 2020
    Copy the full SHA
    292b620 View commit details
    Browse the repository at this point in the history

  11. fix: bad logic in segment foundation handleClick 

    change logic from deny unselect to multiSelect to deny unselect to
singleSelect
    @gschrag
    gschrag committed Jul 14, 2020
    Copy the full SHA
    b9e9cf2 View commit details
    Browse the repository at this point in the history

  12. test: add segment foundation unit tests 

    test new segment foundation business logic
    @gschrag
    gschrag committed Jul 14, 2020
    Copy the full SHA
    ae01397 View commit details
    Browse the repository at this point in the history

  13. refactor: reorganize segmented-button tests, create constants.ts 

    better describe test cases, pull constants into separate files
    @gschrag
    gschrag committed Jul 14, 2020
    Copy the full SHA
    0d8794a View commit details
    Browse the repository at this point in the history

  14. test: update segment test after refactor 

    fix test that fails due to unexpected unnecessary method calls
    @gschrag
    gschrag committed Jul 14, 2020
    Copy the full SHA
    6a4866a View commit details
    Browse the repository at this point in the history

  15. refactor: reorganize constants and other small refactor 

    reorganize for more clear constants files and constant names
    @gschrag
    gschrag committed Jul 14, 2020
    Copy the full SHA
    2c6f042 View commit details
    Browse the repository at this point in the history