refactor: fix up sass division deprecation warnings #7158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The division operator is deprecated and it causes Sass to print a warning in the latest version. These changes migrate to the `math.div` helper.
|
It's rebased @abhiomkar |
|
Thanks @crisbeto ! Imported this change internally. Will merge this after the test results. |
ChadBurggraf
added a commit
to dispoteca/material-components-web
that referenced
this pull request
Aug 24, 2021
This backports PR material-components#7158 to the v5.1 branch so that a new 5.x release can be made. Some popular libraries like [React Material Web Components](https://github.com/jamesmfriedman/rmwc) are based on 5.x. This removes SASS warnings while users migrate to better-supported libraries.
ChadBurggraf
added a commit
to dispoteca/material-components-web
that referenced
this pull request
Aug 24, 2021
This backports PR material-components#7158 to the v5.1 branch so that a new 5.x release can be made. Some popular libraries like [React Material Web Components](https://github.com/jamesmfriedman/rmwc) are based on 5.x. This removes SASS warnings while users migrate to better-supported libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The division operator is deprecated and it causes Sass to print a warning in the latest version. These changes migrate to the
math.divhelper.See https://sass-lang.com/documentation/breaking-changes/slash-div.