Curated Post Block: Improve Post List Display

[ravichdev]

Issue by jauyong
Thursday Dec 10, 2020 at 19:25 GMT
Originally opened as xwp/material-design-wp-plugin#470

---

Feature description

As an editor, I want a way to preview posts so that I can add the correct ones to my curated cards collection block.

Improve how posts are displayed when they have no title.

Current state:

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

1. In situations where Curated Posts (AKA hand-picked posts) show up with no title, show: (no title)
2. Clicking on the "preview" pill will open the post/page in a new tab
3. Fix rounded corners: https://d.pr/i/6hC3tF. The pill showing selected posts should encompass the full title

Design to implement:

Implementation brief

QA testing instructions

Demo

Changelog entry

[ravichdev]

Comment by jauyong
Thursday Dec 10, 2020 at 19:26 GMT

---

• Note: We should examine a UI to try and pull from pages or posts, but not go forward unless we’re confident that its an improvement over the existing state. That UI could show a large list, where posts and pages are shown together, and users can cross select. Worth exploring and seeing if we want to proceed. covered by USER JOURNEY MAP: Document Journey #66
• Fix rounded corners: https://d.pr/i/6hC3tF. covered in AC above
• Two ideas: Have a icon to open the post in a new tab, that way you can preview it; or try having the additional next lines of post display in the preview. (Note: Also take a look at Woo, how handled the ID showing) going to try linkable ID instead of icon.

[ravichdev]

Comment by jauyong
Wednesday Dec 16, 2020 at 18:58 GMT

---

Hey @jwold I think this needs your input on what the outcome should be.

[ravichdev]

Comment by jwold
Thursday Jan 14, 2021 at 20:33 GMT

---

Settled on two approaches we could take for this. Feedback is welcome.

[ravichdev]

Comment by jauyong
Friday Jan 15, 2021 at 16:07 GMT

---

@ravichdev to investigate if these options are viable.

[ravichdev]

Comment by jauyong
Friday Jan 15, 2021 at 16:07 GMT

---

@jwold can you please add a new option C where on the right hand side it will simply say "open" or "preview" or something to that effect. Thanks!

[ravichdev]

Comment by jwold
Friday Jan 15, 2021 at 21:34 GMT

---

Updated:

[ravichdev]

Comment by jauyong
Friday Feb 05, 2021 at 16:54 GMT

---

Need to review options during grooming with the team

[ravichdev]

Comment by jauyong
Friday Feb 05, 2021 at 18:25 GMT

---

@rodydavis when we last discussed this, we wanted to see option C that Joshua provided above. Do you want to discuss in our next grooming or do you want to pick one of the options and move this ticket in "To Do"?

[ravichdev]

Comment by jauyong
Friday Feb 12, 2021 at 16:25 GMT

---

@dawidmlynarz to review option C above. If there are no other changes to discuss, unassign yourself and then an engineer can being working on this.

@jauyong to update AC

[ravichdev]

Comment by dawidmlynarz
Friday Feb 19, 2021 at 12:49 GMT

---

@jauyong I have reviewed Option C and we can go with this as it is proposed by Joshua. Looks good to me!

[ravichdev]

Comment by rodydavis
Friday Feb 19, 2021 at 16:29 GMT

---

LGTM

Rody Davis

On Feb 19, 2021, at 4:49 AM, Dawid Młynarz notifications@github.com wrote:


@jauyong I have reviewed Option C and we can go with this as it is proposed by Joshua. Looks good to me!

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.

[csossi]

"(no title)" isn't appearing, @ravichdev :

[ravichdev]

@csossi This is updated and ready for your review on staging

[csossi]

Verified in QA