Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curated Post Block: Improve Post List Display #470

Closed
jauyong opened this issue Dec 10, 2020 · 11 comments
Closed

Curated Post Block: Improve Post List Display #470

jauyong opened this issue Dec 10, 2020 · 11 comments
Assignees
Projects
Milestone

Comments

@jauyong
Copy link

jauyong commented Dec 10, 2020

Feature description

As an editor, I want a way to preview posts so that I can add the correct ones to my curated cards collection block.

Improve how posts are displayed when they have no title.

Current state:
image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  1. In situations where Curated Posts (AKA hand-picked posts) show up with no title, show: (no title)
  2. Clicking on the "preview" pill will open the post/page in a new tab
  3. Fix rounded corners: https://d.pr/i/6hC3tF. The pill showing selected posts should encompass the full title

Design to implement:
image

Implementation brief

QA testing instructions

Demo

Changelog entry

@jauyong jauyong self-assigned this Dec 10, 2020
@jauyong
Copy link
Author

jauyong commented Dec 10, 2020

  • Note: We should examine a UI to try and pull from pages or posts, but not go forward unless we’re confident that its an improvement over the existing state. That UI could show a large list, where posts and pages are shown together, and users can cross select. Worth exploring and seeing if we want to proceed. covered by Block: Extend curated card collection to support Custom Post Types #66
  • Fix rounded corners: https://d.pr/i/6hC3tF. covered in AC above
  • Two ideas: Have a icon to open the post in a new tab, that way you can preview it; or try having the additional next lines of post display in the preview. (Note: Also take a look at Woo, how handled the ID showing) going to try linkable ID instead of icon.

@jauyong jauyong added this to Backlog in Execution Dec 10, 2020
@jauyong
Copy link
Author

jauyong commented Dec 16, 2020

Hey @jwold I think this needs your input on what the outcome should be.

@jauyong jauyong assigned jwold and unassigned jauyong Dec 16, 2020
@jwold
Copy link

jwold commented Jan 14, 2021

Screen Shot 2021-01-14 at 12 33 05 PM

Settled on two approaches we could take for this. Feedback is welcome.

@jwold jwold removed their assignment Jan 14, 2021
@jauyong
Copy link
Author

jauyong commented Jan 15, 2021

@ravichdev to investigate if these options are viable.

@jauyong
Copy link
Author

jauyong commented Jan 15, 2021

@jwold can you please add a new option C where on the right hand side it will simply say "open" or "preview" or something to that effect. Thanks!

@jwold
Copy link

jwold commented Jan 15, 2021

Updated:

Screen Shot 2021-01-15 at 1 33 47 PM

@jauyong jauyong assigned jauyong and unassigned jwold and ravichdev Feb 5, 2021
@jauyong
Copy link
Author

jauyong commented Feb 5, 2021

Need to review options during grooming with the team

@jauyong
Copy link
Author

jauyong commented Feb 5, 2021

@rodydavis when we last discussed this, we wanted to see option C that Joshua provided above. Do you want to discuss in our next grooming or do you want to pick one of the options and move this ticket in "To Do"?

@jauyong
Copy link
Author

jauyong commented Feb 12, 2021

@dawidmlynarz to review option C above. If there are no other changes to discuss, unassign yourself and then an engineer can being working on this.

@jauyong to update AC

@jauyong jauyong assigned dawidmlynarz and unassigned rodydavis Feb 12, 2021
@dawidmlynarz
Copy link

@jauyong I have reviewed Option C and we can go with this as it is proposed by Joshua. Looks good to me!

@rodydavis
Copy link
Contributor

rodydavis commented Feb 19, 2021 via email

@jauyong jauyong moved this from Backlog to To Do in Execution Feb 25, 2021
@ravichdev ravichdev moved this from To Do to In Progress in Execution Mar 16, 2021
@ravichdev ravichdev self-assigned this Mar 16, 2021
@ravichdev ravichdev moved this from In Progress to Code Review in Execution Mar 18, 2021
@jauyong jauyong added this to the 0.2.0 milestone Mar 19, 2021
Execution automation moved this from Code Review to Done Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Execution
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants