-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[M3] Components - Tab #324
Comments
Tab require migration from m2 to m3 since typography class is changes as per https://github.com/material-components/material-design-for-wordpress/pull/370/files#diff-858e445f1f1095a52fdf04e1505b6d33eca98e9eb4e0c27d909e1d75dea6f9a5 |
QA note: Test material tab block with m3 typography and color token. |
Hello @igruszkauy Good catch, I've already created PR for that fix #418, I found the issue while preparing for demo. |
After adding the tab and going to the page if I go to customizer and change the source color, it still has some issues with the color of the inactive tabs, unless I go and change the dark/light mode https://dev-mdc-web.pantheonsite.io/tab-test/ |
Good catch @igruszkauy, This is because when re-generating color on customizer, we are not computing and injecting RGB CSV value which is used at various places. This is not specific to tab, I will create a new PR to fix this. More details on this comment: #330 (comment) |
verified via: https://dev-mdc-web.pantheonsite.io/tab-test/ Issue fixed: After adding the tab and going to the page if I go to customizer and change the source color, it still has some issues with the color of the inactive tabs, unless I go and change the dark/light mode |
Feature description
Update Tab component to match M3 style
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: