Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M3] Components - Tab #324

Closed
igruszkauy opened this issue Apr 2, 2022 · 7 comments · Fixed by #407, #409 or #432
Closed

[M3] Components - Tab #324

igruszkauy opened this issue Apr 2, 2022 · 7 comments · Fixed by #407, #409 or #432
Projects
Milestone

Comments

@igruszkauy
Copy link
Collaborator

igruszkauy commented Apr 2, 2022

Feature description

Update Tab component to match M3 style


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Tab block is replaced with m3 specs as provided by MDC
  • When the user opens Gutenberg page with m2 component it automatically migrates to M3

Implementation brief

QA testing instructions

Demo

Changelog entry

@igruszkauy igruszkauy added this to To Groom / Define in Execution Apr 2, 2022
@igruszkauy igruszkauy moved this from To Groom / Define to Blocked in Execution May 25, 2022
@PatelUtkarsh PatelUtkarsh added this to the M3 milestone Jun 25, 2022
@igruszkauy igruszkauy moved this from Blocked to To Do in Execution Aug 2, 2022
@PatelUtkarsh PatelUtkarsh self-assigned this Aug 3, 2022
@PatelUtkarsh PatelUtkarsh moved this from To Do to In Progress in Execution Aug 3, 2022
@PatelUtkarsh PatelUtkarsh mentioned this issue Aug 3, 2022
3 tasks
@PatelUtkarsh PatelUtkarsh moved this from In Progress to Code Review in Execution Aug 4, 2022
Execution automation moved this from Code Review to Done Aug 4, 2022
@PatelUtkarsh PatelUtkarsh moved this from Done to QA in Execution Aug 8, 2022
@PatelUtkarsh PatelUtkarsh moved this from QA to In Progress in Execution Aug 8, 2022
@PatelUtkarsh
Copy link
Collaborator

@PatelUtkarsh PatelUtkarsh reopened this Aug 8, 2022
@PatelUtkarsh PatelUtkarsh moved this from In Progress to Code Review in Execution Aug 8, 2022
Execution automation moved this from Code Review to Done Aug 10, 2022
@PatelUtkarsh PatelUtkarsh moved this from Done to QA in Execution Aug 11, 2022
@PatelUtkarsh PatelUtkarsh assigned igruszkauy and unassigned emeaguiar Aug 11, 2022
@PatelUtkarsh
Copy link
Collaborator

QA note: Test material tab block with m3 typography and color token.

@igruszkauy
Copy link
Collaborator Author

Verified via local environment and zips provided for M3 version:
M2:
image

After updating M3:
image

  • I think there is an issue, the component doesn't display correctly on dark mode, the titles are in black and cannot be read properly. Also, when changing the source color it applies the dark scheme and the switch behaves in a strange way
tab.component.mov
  • Verified changing typography works:
    image

@igruszkauy igruszkauy moved this from QA to In Progress in Execution Aug 15, 2022
@PatelUtkarsh
Copy link
Collaborator

Hello @igruszkauy Good catch, I've already created PR for that fix #418, I found the issue while preparing for demo.

@PatelUtkarsh PatelUtkarsh moved this from In Progress to Code Review in Execution Aug 16, 2022
@PatelUtkarsh PatelUtkarsh moved this from Code Review to QA in Execution Aug 19, 2022
@PatelUtkarsh PatelUtkarsh assigned igruszkauy and unassigned emeaguiar Aug 19, 2022
@igruszkauy
Copy link
Collaborator Author

After adding the tab and going to the page if I go to customizer and change the source color, it still has some issues with the color of the inactive tabs, unless I go and change the dark/light mode

https://dev-mdc-web.pantheonsite.io/tab-test/
https://user-images.githubusercontent.com/2902880/185611046-ec550815-d312-4ea3-911c-4f91df24158c.mov

@igruszkauy igruszkauy moved this from QA to To Do in Execution Aug 19, 2022
@PatelUtkarsh
Copy link
Collaborator

Good catch @igruszkauy,

This is because when re-generating color on customizer, we are not computing and injecting RGB CSV value which is used at various places. This is not specific to tab, I will create a new PR to fix this.

More details on this comment: #330 (comment)

@PatelUtkarsh PatelUtkarsh moved this from To Do to In Progress in Execution Aug 23, 2022
@PatelUtkarsh PatelUtkarsh moved this from In Progress to Code Review in Execution Aug 23, 2022
@emeaguiar emeaguiar moved this from Code Review to QA in Execution Aug 25, 2022
@igruszkauy
Copy link
Collaborator Author

verified via: https://dev-mdc-web.pantheonsite.io/tab-test/

Issue fixed: After adding the tab and going to the page if I go to customizer and change the source color, it still has some issues with the color of the inactive tabs, unless I go and change the dark/light mode

@igruszkauy igruszkauy moved this from QA to Demo in Execution Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment