Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle tab depreciation #409

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Handle tab depreciation #409

merged 2 commits into from
Aug 10, 2022

Conversation

PatelUtkarsh
Copy link
Collaborator

Summary

Fixes #324

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

@PatelUtkarsh PatelUtkarsh changed the title Add tab deprecated Add tab deprecate handler Aug 9, 2022
@PatelUtkarsh PatelUtkarsh changed the title Add tab deprecate handler Handle tab depreciation Aug 9, 2022
Base automatically changed from m3/list to develop August 10, 2022 14:30
@emeaguiar emeaguiar merged commit d20aec1 into develop Aug 10, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2833427885

  • 4 of 9 (44.44%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-30.5%) to 41.815%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/assets/src/block-editor/blocks/tab-bar/deprecated/m2/m2-tab-save.js 3 8 37.5%
Totals Coverage Status
Change from base Build 2833412080: -30.5%
Covered Lines: 1457
Relevant Lines: 3217
💛 - Coveralls

@emeaguiar emeaguiar deleted the m3/tab-deprecated branch August 10, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emeaguiar emeaguiar emeaguiar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[M3] Components - Tab
3 participants
@PatelUtkarsh @coveralls @emeaguiar