Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M3] Components - Form #326

Closed
igruszkauy opened this issue Apr 2, 2022 · 7 comments · Fixed by #401 or #427
Closed

[M3] Components - Form #326

igruszkauy opened this issue Apr 2, 2022 · 7 comments · Fixed by #401 or #427
Projects
Milestone

Comments

@igruszkauy
Copy link
Collaborator

igruszkauy commented Apr 2, 2022

Feature description

Update Form component to match M3 style.

Specs: https://m3.material.io/components/text-fields/specs

Figma: https://www.figma.com/file/pHzNW5Ef6zckGSMqQWY0m3/Material-3-Design-Kit-(Community)?node-id=51189%3A6055


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Form and it's input element block is replaced with m3 specs as provided by MDC
  • When the user opens Gutenberg page with m2 component, it automatically migrates to M3

• Components affected:

  • material/contact-form
    • material/email-input-field
    • material/message-input-field
    • material/name-input-field
    • material/short-text-input-field
    • material/website-input-field

Implementation brief

QA testing instructions

Demo

Changelog entry

@igruszkauy igruszkauy added this to To Groom / Define in Execution Apr 2, 2022
@igruszkauy igruszkauy moved this from To Groom / Define to Blocked in Execution May 25, 2022
@PatelUtkarsh PatelUtkarsh added this to the M3 milestone Jun 25, 2022
@igruszkauy igruszkauy moved this from Blocked to To Do in Execution Jul 19, 2022
@PatelUtkarsh PatelUtkarsh self-assigned this Jul 28, 2022
@PatelUtkarsh PatelUtkarsh moved this from To Do to In Progress in Execution Jul 28, 2022
@PatelUtkarsh PatelUtkarsh mentioned this issue Aug 3, 2022
3 tasks
@PatelUtkarsh
Copy link
Collaborator

Note the buttons are handled in #325.

Demo:

text-field.mp4

@PatelUtkarsh PatelUtkarsh moved this from In Progress to Code Review in Execution Aug 3, 2022
Execution automation moved this from Code Review to Done Aug 4, 2022
@PatelUtkarsh PatelUtkarsh moved this from Done to QA in Execution Aug 8, 2022
@igruszkauy
Copy link
Collaborator Author

Verified via local environment and zips provided for M3 version:
M2: image

After updating M3:
image

  • Shouldn't text label be in color when writing?
    image
    image

  • Verified I can change typography:
    image

Q: Don't we have the possibility of adding the supporting text and icon to the fields as shown in figma?
image

@igruszkauy igruszkauy moved this from QA to In Progress in Execution Aug 15, 2022
@PatelUtkarsh
Copy link
Collaborator

Hello @igruszkauy, Currently we don't have it, Should we create a ticket and track it?

@PatelUtkarsh
Copy link
Collaborator

Shouldn't text label be in color when writing?

Yes, I think it should change, Let me take a look.

@PatelUtkarsh
Copy link
Collaborator

PatelUtkarsh commented Aug 16, 2022

PR created to fix label color on focus: #427

@PatelUtkarsh PatelUtkarsh moved this from In Progress to Code Review in Execution Aug 16, 2022
@igruszkauy
Copy link
Collaborator Author

Added ticket for support text and icon for text-fields #428

@PatelUtkarsh PatelUtkarsh moved this from Code Review to QA in Execution Aug 19, 2022
@PatelUtkarsh PatelUtkarsh assigned igruszkauy and unassigned emeaguiar Aug 19, 2022
@igruszkauy
Copy link
Collaborator Author

Verified via: https://dev-mdc-web.pantheonsite.io/form-test/
Label color on focus working as expected:
image

@igruszkauy igruszkauy removed their assignment Aug 20, 2022
@igruszkauy igruszkauy moved this from QA to Demo in Execution Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
4 participants