Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M3] Components - Button #325

Closed
igruszkauy opened this issue Apr 2, 2022 · 5 comments · Fixed by #417, #438 or #439
Closed

[M3] Components - Button #325

igruszkauy opened this issue Apr 2, 2022 · 5 comments · Fixed by #417, #438 or #439
Assignees
Projects
Milestone

Comments

@igruszkauy
Copy link
Collaborator

igruszkauy commented Apr 2, 2022

Feature description

Update Button component to match M3 style

Button specs: https://m3.material.io/components/buttons/specs


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Button block is replaced with m3 specs as provided by MDC
  • When the user opens Gutenberg page with m2 component it automatically migrates to M3
  • FAB component is not added
  • "Large" button retains the name but the styling is based on the FAB "extended" component as described in https://rodydavis.github.io/material-design-lite/components/button/
  • "Large" button doesn't have corner radius slider and has fixed min height

Implementation brief

QA testing instructions

Demo

Changelog entry

@igruszkauy igruszkauy added this to To Groom / Define in Execution Apr 2, 2022
@igruszkauy igruszkauy moved this from To Groom / Define to Blocked in Execution May 25, 2022
@PatelUtkarsh PatelUtkarsh added this to the M3 milestone Jun 25, 2022
@igruszkauy igruszkauy moved this from Blocked to To Do in Execution Jul 19, 2022
@emeaguiar emeaguiar moved this from To Do to In Progress in Execution Jul 25, 2022
@emeaguiar emeaguiar self-assigned this Jul 25, 2022
@emeaguiar emeaguiar mentioned this issue Aug 10, 2022
3 tasks
@emeaguiar emeaguiar moved this from In Progress to Code Review in Execution Aug 10, 2022
Execution automation moved this from Code Review to Done Aug 23, 2022
@PatelUtkarsh PatelUtkarsh moved this from Done to QA in Execution Aug 23, 2022
@PatelUtkarsh
Copy link
Collaborator

Hello @igruszkauy, This is ready for testing.

  1. Add m2 material button block using wp.org version.
  2. Add new m3 zip from attachment.
  3. Verify m2 is migrated to m3.
  4. Verify m3 button follows specs as mentioned in ticket desc.

Theme: https://s.utkarshpatel.com/material-design-google-theme-9AW4x.zip
Plugin: https://s.utkarshpatel.com/material-design-plugin-fP0CK.zip

@PatelUtkarsh
Copy link
Collaborator

@emeaguiar emeaguiar mentioned this issue Aug 26, 2022
3 tasks
Execution automation moved this from In Progress to Done Aug 26, 2022
@PatelUtkarsh PatelUtkarsh reopened this Aug 26, 2022
@PatelUtkarsh PatelUtkarsh moved this from Done to QA in Execution Aug 26, 2022
@PatelUtkarsh PatelUtkarsh assigned igruszkauy and unassigned emeaguiar Aug 26, 2022
@igruszkauy
Copy link
Collaborator Author

Verified via local environment.
M2:
M2 button

Migrated to M3:
normal outlined

  1. Raised button is not using primary color for label:

image

  1. If there were large buttons with other variations different than text, when migrated, they are migrated to the normal version with the corresponding variant. I am not sure if this was what we agreed? it looks confusing.

image

@igruszkauy igruszkauy assigned emeaguiar and unassigned igruszkauy Aug 26, 2022
@igruszkauy igruszkauy moved this from QA to In Progress in Execution Aug 26, 2022
@emeaguiar emeaguiar mentioned this issue Aug 26, 2022
3 tasks
@emeaguiar
Copy link
Collaborator

@igruszkauy I updated the color of "Elevated (raised)" to be the correct one.

I can't reproduce 2, all my buttons were migrated to be large, perhaps your version is not up to date? this was a very recent update (merged early today)

M2 Screen Shot 2022-08-26 at 10 54 00
M3 Screen Shot 2022-08-26 at 10 58 35

I did find an issue with border displaying when it shouldn't, I have sent #439 to address both issues

@emeaguiar emeaguiar reopened this Aug 26, 2022
@emeaguiar emeaguiar moved this from In Progress to Code Review in Execution Aug 26, 2022
@igruszkauy
Copy link
Collaborator Author

@emeaguiar can you send me new zips for plugin and theme to check color and test again the large button? I used the zips @PatelUtkarsh sent today

Execution automation moved this from Code Review to Done Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment