Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M3] Color and Background color to support M3 tokens #354

Closed
igruszkauy opened this issue May 3, 2022 · 8 comments · Fixed by #385 or #419
Closed

[M3] Color and Background color to support M3 tokens #354

igruszkauy opened this issue May 3, 2022 · 8 comments · Fixed by #385 or #419
Projects
Milestone

Comments

@igruszkauy
Copy link
Collaborator

igruszkauy commented May 3, 2022

Feature description


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The user can use M3 tokens from Gutenberg

Implementation brief

QA testing instructions

  • User is able to choose any of the M3 colors registred

Demo

Changelog entry

@igruszkauy igruszkauy added this to To Groom / Define in Execution May 3, 2022
@igruszkauy igruszkauy moved this from To Groom / Define to To Do in Execution May 17, 2022
@PatelUtkarsh PatelUtkarsh added this to the M3 milestone Jun 25, 2022
@PatelUtkarsh
Copy link
Collaborator

Using Gutenberg's default color picker, It should display m3 tokens for text and background colors.

@emeaguiar This is different from customizer.

image

@igruszkauy igruszkauy changed the title [M3] Color picker to support M3 tokens [M3] Color and Background color to support M3 tokens Jul 8, 2022
@mattchungxwp
Copy link
Collaborator

Confirm with @rodydavis : Should we continue to use static palette or generated M3 colors?

@rodydavis
Copy link
Member

Use the new generated ones!

@PatelUtkarsh PatelUtkarsh moved this from To Do to Code Review in Execution Jul 14, 2022
Execution automation moved this from Code Review to Done Jul 14, 2022
@PatelUtkarsh PatelUtkarsh moved this from Done to QA in Execution Jul 14, 2022
@PatelUtkarsh
Copy link
Collaborator

QA note: Gutenberg text and background color should show m3 token:

image

@felipebochehin87
Copy link
Collaborator

@igruszkauy @PatelUtkarsh the functionality looks good so far. Tested using https://dev-mdc-web.pantheonsite.io/wp-admin/post.php?post=2665&action=edit

  1. Added a Media & Text block
  2. Clicked on the text
  3. Opened More Settings Menu
  4. Changed color (background and text)
  5. Selected default colors and also custom colors

My questions are (and I'm opening as questions because I'd like to confirm if that's expected before saying it's a bug):

  1. We have a "check" on the selected color, but this check is white. This makes the check invisible when we select the white color. Is it possible (and necessary) to change the color of the check when the selected color is white so that the check is visible?
  2. The custom color is not displayed on the list of colors. Is that expected? Click on Custom color, select a color, collapse the color picker, expand the color picker - the custom color remains applied to the text, but it is not listed in the color picker. Should we display the color and the check on it to show what color is selected?

expanded
collapsed

@igruszkauy
Copy link
Collaborator Author

igruszkauy commented Jul 15, 2022

@felipebochehin87 thank you for the questions!

  • The check and font color of the name of the color should be white/black depending on the selected color
  • Custom color is displayed, I think you need to re-test, this is what I am seeing now: Screen Shot 2022-07-15 at 11 47 52
    @emeaguiar I think I missed what we agreed with the name of the color? Currently showing the css name

@igruszkauy igruszkauy moved this from QA to In Progress in Execution Jul 15, 2022
@felipebochehin87
Copy link
Collaborator

felipebochehin87 commented Jul 15, 2022

Thanks @igruszkauy !!

About my second question: I thought that the custom color was supposed to be displayed along with the other colors, in a circle, just like the others. Now I see, the custom will be displayed on the rectangle. Thanks! :)

And about the first, yeah, I don't see the check when I select white.

@emeaguiar emeaguiar moved this from In Progress to Code Review in Execution Aug 9, 2022
@emeaguiar emeaguiar mentioned this issue Aug 11, 2022
3 tasks
@PatelUtkarsh PatelUtkarsh reopened this Aug 16, 2022
@mattchungxwp mattchungxwp moved this from Code Review to To Do in Execution Aug 16, 2022
@mattchungxwp mattchungxwp moved this from To Do to In Progress in Execution Aug 16, 2022
Execution automation moved this from In Progress to Done Aug 24, 2022
@PatelUtkarsh PatelUtkarsh moved this from Done to QA in Execution Aug 25, 2022
@igruszkauy igruszkauy moved this from QA to Demo in Execution Aug 25, 2022
@igruszkauy
Copy link
Collaborator Author

Verified via: https://dev-mdc-web.pantheonsite.io/2744-2/

  1. Added a paragraph, I can change the color and background using M3 colorshttps://dev-mdc-web.pantheonsite.io/2744-2/
  2. When updating source color from customizer, the color and background from paragraph are updated

image

Known issues that need to be handled by core:

  1. Name of the color to be more user friendly

image

  1. Color of the font for the name of the color is white and can't be seen when selecting a light color

image

@igruszkauy igruszkauy removed their assignment Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
6 participants