Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core color picker #419

Merged
merged 18 commits into from
Aug 24, 2022
Merged

Core color picker #419

merged 18 commits into from
Aug 24, 2022

Conversation

emeaguiar
Copy link
Collaborator

Summary

Fixes #354

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

@coveralls
Copy link

coveralls commented Aug 11, 2022

Pull Request Test Coverage Report for Build 2865762665

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 72.97%

Totals Coverage Status
Change from base Build 2835107180: 0.8%
Covered Lines: 4683
Relevant Lines: 6292

💛 - Coveralls

@PatelUtkarsh
Copy link
Collaborator

Two things on this: @emeaguiar

  1. useSetting is not available on 5.6 WP, which is our minimum support version.
  2. Colour are not showing correctly on latest WP based on generated colors.

# Conflicts:
#	plugin/assets/src/block-editor/blocks/button/edit.js
@PatelUtkarsh
Copy link
Collaborator

For point 2:

I cleaned up the existing global style in order for this to work:

DELETE FROM wp_posts WHERE post_type = 'wp_global_styles'

PatelUtkarsh
PatelUtkarsh previously approved these changes Aug 24, 2022
- Skip list test #392
- See PR #389
@emeaguiar emeaguiar merged commit 7904ade into develop Aug 24, 2022
@emeaguiar emeaguiar deleted the feature/354-color-palette branch August 24, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[M3] Color and Background color to support M3 tokens
3 participants