Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M3] Plugin update admin notice and color migration #400

Closed
igruszkauy opened this issue Aug 2, 2022 · 6 comments
Closed

[M3] Plugin update admin notice and color migration #400

igruszkauy opened this issue Aug 2, 2022 · 6 comments
Projects
Milestone

Comments

@igruszkauy
Copy link
Collaborator

igruszkauy commented Aug 2, 2022

Feature description

Upon plugin install, show admin notice or the user to select source color


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • When user updates plugin an admin notice is displayed to notify the user the site has been updated to Material Design 3 and that the color palette is going to be generated using primary color.
  • Admin notice shows the following message "Your site has been updated with Material Design 3. The color palette will be generated dynamically from primary color. You can preview the site and change the source color from customizer."
  • Admin notice shows CTA "Go to Customizer", user can click to go to customizer, preview the site and select source color (navigate directly to color panel).
  • While the notice is open: In background (in javascript), m2 primary color should be used to generate m3 color tokens and saved to the relevant customizer setting. (Assume that some user may skip this notice).

Implementation brief

QA testing instructions

Demo

Changelog entry

@igruszkauy igruszkauy added this to To Groom / Define in Execution Aug 2, 2022
@PatelUtkarsh
Copy link
Collaborator

How about following? @igruszkauy

Your site is updated with Material Design 3, The site's color palette will be generated dynamically from primary color, please go to customizer to change source color.

@PatelUtkarsh PatelUtkarsh added this to the M3 milestone Aug 3, 2022
@igruszkauy
Copy link
Collaborator Author

@PatelUtkarsh I like it, what about making the following adjustments?

Your site has been updated with Material Design 3. The color palette will be generated dynamically from primary color, please go to customizer to select a source color.

@igruszkauy
Copy link
Collaborator Author

igruszkauy commented Aug 3, 2022

@rodydavis can you please review the messaging?

Your site has been updated with Material Design 3. The color palette will be generated dynamically from primary color. You can preview the site and change the source color from customizer.

@igruszkauy igruszkauy moved this from To Groom / Define to To Do in Execution Aug 9, 2022
@rodydavis
Copy link
Member

LGTM

@PatelUtkarsh PatelUtkarsh changed the title [M3] Plugin update admin notice [M3] Plugin update admin notice and color migration Aug 16, 2022
@PatelUtkarsh PatelUtkarsh self-assigned this Aug 16, 2022
@PatelUtkarsh PatelUtkarsh moved this from To Do to In Progress in Execution Aug 16, 2022
@PatelUtkarsh PatelUtkarsh moved this from In Progress to QA in Execution Aug 23, 2022
@PatelUtkarsh
Copy link
Collaborator

For testing you can use zip from: #325 (comment)

@igruszkauy
Copy link
Collaborator Author

Verified via local environment updating theme and plugin

  1. Updated theme and plugin and verified admin notice is displayed and links to customizer
  2. M2 primary color us used to automatically generate M3 colors

@igruszkauy igruszkauy moved this from QA to Demo in Execution Aug 23, 2022
Execution automation moved this from Demo to Done Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants