Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M3] Ripple #405

Closed
PatelUtkarsh opened this issue Aug 3, 2022 · 6 comments · Fixed by #413
Closed

[M3] Ripple #405

PatelUtkarsh opened this issue Aug 3, 2022 · 6 comments · Fixed by #413
Projects
Milestone

Comments

@PatelUtkarsh
Copy link
Collaborator

Feature description

Replace m2's @material/ripple/dist/mdc.ripple.css style with m3 tokens.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@PatelUtkarsh PatelUtkarsh added this to the M3 milestone Aug 3, 2022
@PatelUtkarsh PatelUtkarsh added this to To Groom / Define in Execution Aug 3, 2022
@PatelUtkarsh PatelUtkarsh self-assigned this Aug 9, 2022
@PatelUtkarsh PatelUtkarsh moved this from To Groom / Define to In Progress in Execution Aug 9, 2022
@PatelUtkarsh PatelUtkarsh mentioned this issue Aug 9, 2022
3 tasks
@PatelUtkarsh PatelUtkarsh moved this from In Progress to Code Review in Execution Aug 9, 2022
Execution automation moved this from Code Review to Done Aug 19, 2022
@PatelUtkarsh PatelUtkarsh moved this from Done to QA in Execution Aug 19, 2022
@PatelUtkarsh
Copy link
Collaborator Author

QA notes:

@PatelUtkarsh PatelUtkarsh assigned igruszkauy and unassigned emeaguiar Aug 19, 2022
@igruszkauy
Copy link
Collaborator

@PatelUtkarsh verified via:
https://dev-mdc-web.pantheonsite.io/ripple-test/
Looks good, both on list mouseover and search/dark mode/hamburger menu icons

The only two things to note,I am not sure are related:

  1. The color in dark mode is very unperceivable:
    image

vs M2
image

  1. Scroll to top button is looking broken, is this related to button component not being ready?
    image

Sending ticket to "review" to analyze the above items.

@igruszkauy igruszkauy moved this from QA to Review in Execution Aug 20, 2022
@PatelUtkarsh PatelUtkarsh mentioned this issue Aug 24, 2022
3 tasks
@PatelUtkarsh
Copy link
Collaborator Author

PatelUtkarsh commented Aug 24, 2022

Hello @igruszkauy,

  1. Fixed list color in Update patterns m3 #433
  2. Button changes are part of [M3] Components - Button #325 - Should be fixed on dev since we merged first version.

image

@PatelUtkarsh PatelUtkarsh moved this from Review to Code Review in Execution Aug 24, 2022
@emeaguiar emeaguiar moved this from Code Review to QA in Execution Aug 25, 2022
@igruszkauy
Copy link
Collaborator

@PatelUtkarsh Verified via:https://dev-mdc-web.pantheonsite.io/new-ripple-test/

  1. List color seems to be the same
    image
  2. Button seems to be as expected now
    image

@igruszkauy igruszkauy assigned PatelUtkarsh and unassigned emeaguiar Aug 25, 2022
@igruszkauy igruszkauy moved this from QA to In Progress in Execution Aug 25, 2022
@PatelUtkarsh
Copy link
Collaborator Author

PatelUtkarsh commented Aug 25, 2022

  1. You can compare dark mode list vs new dark mode, colour is more light. @igruszkauy
Before fix After fix
image image

@PatelUtkarsh PatelUtkarsh removed their assignment Aug 25, 2022
@PatelUtkarsh PatelUtkarsh moved this from In Progress to QA in Execution Aug 25, 2022
@igruszkauy
Copy link
Collaborator

igruszkauy commented Aug 25, 2022

Sending to "Demo" as per comment above.

@igruszkauy igruszkauy removed their assignment Aug 25, 2022
@igruszkauy igruszkauy moved this from QA to Demo in Execution Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants