Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme #50

Closed
ravichdev opened this issue Apr 13, 2021 · 3 comments
Closed

Dark theme #50

ravichdev opened this issue Apr 13, 2021 · 3 comments

Comments

@ravichdev
Copy link
Contributor

Issue by jwold
Wednesday Mar 04, 2020 at 16:06 GMT
Originally opened as xwp/material-design-wp-plugin#76


Feature description

Material offers guidelines for creating dark and light theme UI. This is worth exploring for a future iteration.

https://material.io/design/color/dark-theme.html#

Theme

Conditional:

  • Theme must be installed

Notes

  • Surface, and on-surface are two additional colors that the dark mode would need to reveal: https://d.pr/i/Dj7Y1Y
  • When you turn on dark mode, the surface colors will change to their respective opposites, and no actual user facing controls will be needed.
  • Border outline looks at on-surface and creates a relevant border as a result
  • We need to look at how other components are impacted. @ravichdev suggested he could compile a list.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@ravichdev
Copy link
Contributor Author

Comment by jwold
Friday Apr 10, 2020 at 21:09 GMT


  • Postpone for a little bit, but hopefully in Q3-Q4 we can revisit. May be Phase 2.
  • Media query selector is how it would work
  • Two options: individually chose dark each time, or default to dark/light and every design style follows
  • MDC web isn't ready yet. Nice if we had that ready before we implement it.

@ravichdev
Copy link
Contributor Author

Comment by jwold
Monday Aug 10, 2020 at 18:30 GMT


Note: This would be something we need to explore manually, since the Material web components do not currently contain the ability to create a dark mode style. However, there is guidance on dark mode, so we can follow that guidance and propose what this could look like using the Material docs.

@jauyong jauyong added this to Backlog in Execution Jun 3, 2021
@jauyong
Copy link
Collaborator

jauyong commented Sep 16, 2021

Closing this as it is a placeholder ticket and the PR for darkmode has been created

@jauyong jauyong closed this as completed Sep 16, 2021
Execution automation moved this from Backlog to Done Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants