Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme #76

Open
jwold opened this issue Mar 4, 2020 · 2 comments
Open

Dark theme #76

jwold opened this issue Mar 4, 2020 · 2 comments

Comments

@jwold
Copy link

jwold commented Mar 4, 2020

Feature description

Material offers guidelines for creating dark and light theme UI. This is worth exploring for a future iteration.

https://material.io/design/color/dark-theme.html#

Theme

Conditional:

  • Theme must be installed

Notes

  • Surface, and on-surface are two additional colors that the dark mode would need to reveal: https://d.pr/i/Dj7Y1Y
  • When you turn on dark mode, the surface colors will change to their respective opposites, and no actual user facing controls will be needed.
  • Border outline looks at on-surface and creates a relevant border as a result
  • We need to look at how other components are impacted. @ravichdev suggested he could compile a list.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@jwold jwold added this to Prioritization in Definition via automation Mar 4, 2020
@jwold jwold moved this from Prioritization to Revisit Later in Definition Mar 4, 2020
@jwold jwold moved this from Revisit Later to Prioritization in Definition Mar 23, 2020
@jwold jwold added the Sprint 5 label Mar 23, 2020
@jwold jwold added the SP 8 label Apr 1, 2020
@jwold jwold moved this from Prioritization to Revisit Later in Definition Apr 6, 2020
@jwold jwold added Phase 2 and removed Sprint 5 labels Apr 6, 2020
@jwold
Copy link
Author

jwold commented Apr 10, 2020

  • Postpone for a little bit, but hopefully in Q3-Q4 we can revisit. May be Phase 2.
  • Media query selector is how it would work
  • Two options: individually chose dark each time, or default to dark/light and every design style follows
  • MDC web isn't ready yet. Nice if we had that ready before we implement it.

@jwold
Copy link
Author

jwold commented Aug 10, 2020

Note: This would be something we need to explore manually, since the Material web components do not currently contain the ability to create a dark mode style. However, there is guidance on dark mode, so we can follow that guidance and propose what this could look like using the Material docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Definition
Revisit Later
Development

No branches or pull requests

1 participant