-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Settings for Card Collections Block #61
Comments
Comment by jauyong @dawidmlynarz to continue reviewing Joshua's mocks on #496 |
This will be lowest priority in 0.3 |
Note: the blue background on the warning may no longer be part of core so Mario used yellow instead |
@PatelUtkarsh - what was updated here? I took a look at the staging site and what I'm seeing has a number of differences with the mock-ups above |
Here is before and after: Before: before.mp4After: after.mp4I've changed card style to elevation because that's a more appropriate word for it, which fits material guidelines. @emeaguiar The gutter in mockup is with card settings section but we have it in card style, Is that something we should change or keep it? |
@emeaguiar to verify if the design mock is outdated or if changes need to be made. |
@PatelUtkarsh I'm not really sure why I didn't initially moved it, probably just missed the second image, I've created #224 to handle that |
@csossi This is updated, Can you verify on test site? |
@csossi You can reference the mockups in the description for correct positioning of the settings. |
Verified in QA |
Issue by jauyong
Monday Dec 07, 2020 at 14:36 GMT
Originally opened as xwp/material-design-wp-plugin#465
Feature description
Review Global vs child settings in the block and compare to how we’ve handled it before(list block).See related ticket #377 #496
Note: consider using the in context menu as opposed to the side bar with optionsUpdate the more settings side panel based on the mocks.
Design Mocks:
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Side Panel settings should flow as follows:
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: