Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Settings for Card Collections Block #61

Closed
ravichdev opened this issue Apr 13, 2021 · 13 comments · Fixed by #211 or #224
Closed

Update Settings for Card Collections Block #61

ravichdev opened this issue Apr 13, 2021 · 13 comments · Fixed by #211 or #224
Projects
Milestone

Comments

@ravichdev
Copy link
Contributor

Issue by jauyong
Monday Dec 07, 2020 at 14:36 GMT
Originally opened as xwp/material-design-wp-plugin#465


Feature description

Review Global vs child settings in the block and compare to how we’ve handled it before(list block).
See related ticket #377 #496

Note: consider using the in context menu as opposed to the side bar with options

Update the more settings side panel based on the mocks.

Design Mocks:
image
image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Side Panel settings should flow as follows:

  1. Style
    1. Masonry
    2. List
    3. Grid
  2. Card Style
  3. Corner Radius
  4. Card Settings
    1. Content Layout
    2. Cards Layout
    3. Columns
    4. Gutter
  5. Content

Implementation brief

QA testing instructions

Demo

Changelog entry

@ravichdev ravichdev added this to the 0.3.0 milestone Apr 13, 2021
@ravichdev
Copy link
Contributor Author

Comment by jauyong
Monday Dec 07, 2020 at 17:28 GMT


@jauyong to update AC to indicate we will do what we did for the list block

@ravichdev
Copy link
Contributor Author

Comment by jauyong
Friday Dec 18, 2020 at 16:52 GMT


@jauyong to open new discovery ticket (list block) to inform this ticket.

@ravichdev
Copy link
Contributor Author

Comment by jwold
Thursday Jan 14, 2021 at 20:45 GMT


Blocked temporarily until I can test out the list block. Requested @jauyong to open a ticket to investigate.

@ravichdev
Copy link
Contributor Author

Comment by jauyong
Friday Feb 12, 2021 at 16:44 GMT


@dawidmlynarz to continue reviewing Joshua's mocks on #496

@jauyong
Copy link
Collaborator

jauyong commented Apr 21, 2021

This will be lowest priority in 0.3

@jauyong jauyong added this to To Do in Execution Apr 28, 2021
@PatelUtkarsh PatelUtkarsh removed this from the 0.3.0 milestone Jun 3, 2021
@jauyong jauyong changed the title Card Collections Block Review Update Settings for Card Collections Block Sep 15, 2021
@emeaguiar emeaguiar moved this from To Do to In Progress in Execution Sep 21, 2021
@emeaguiar emeaguiar self-assigned this Sep 21, 2021
@jauyong
Copy link
Collaborator

jauyong commented Sep 23, 2021

Note: the blue background on the warning may no longer be part of core so Mario used yellow instead

@emeaguiar emeaguiar mentioned this issue Sep 23, 2021
3 tasks
@PatelUtkarsh PatelUtkarsh moved this from In Progress to Code Review in Execution Sep 27, 2021
Execution automation moved this from Code Review to Done Oct 5, 2021
@PatelUtkarsh PatelUtkarsh moved this from Done to QA in Execution Oct 5, 2021
@PatelUtkarsh PatelUtkarsh assigned csossi and unassigned emeaguiar Oct 7, 2021
@csossi
Copy link
Collaborator

csossi commented Oct 14, 2021

@PatelUtkarsh - what was updated here? I took a look at the staging site and what I'm seeing has a number of differences with the mock-ups above

@csossi csossi moved this from QA to In Progress in Execution Oct 14, 2021
@PatelUtkarsh
Copy link
Collaborator

Here is before and after:

Before:

before.mp4

After:

after.mp4

I've changed card style to elevation because that's a more appropriate word for it, which fits material guidelines.

@emeaguiar The gutter in mockup is with card settings section but we have it in card style, Is that something we should change or keep it?

@jauyong
Copy link
Collaborator

jauyong commented Oct 28, 2021

@emeaguiar to verify if the design mock is outdated or if changes need to be made.

@emeaguiar
Copy link
Collaborator

@PatelUtkarsh I'm not really sure why I didn't initially moved it, probably just missed the second image, I've created #224 to handle that

@emeaguiar emeaguiar moved this from In Progress to Code Review in Execution Nov 2, 2021
@jauyong jauyong assigned PatelUtkarsh and unassigned emeaguiar Nov 2, 2021
@PatelUtkarsh PatelUtkarsh moved this from Code Review to QA in Execution Nov 3, 2021
@PatelUtkarsh PatelUtkarsh assigned csossi and unassigned PatelUtkarsh Nov 3, 2021
@PatelUtkarsh
Copy link
Collaborator

@csossi This is updated, Can you verify on test site?

@PatelUtkarsh PatelUtkarsh added this to the 0.4.1 milestone Nov 8, 2021
This was referenced Nov 8, 2021
@jauyong
Copy link
Collaborator

jauyong commented Nov 11, 2021

@csossi You can reference the mockups in the description for correct positioning of the settings.

@csossi
Copy link
Collaborator

csossi commented Nov 20, 2021

Verified in QA

@csossi csossi removed their assignment Nov 20, 2021
@csossi csossi moved this from QA to Demo in Execution Nov 20, 2021
@igruszkauy igruszkauy moved this from Demo to Approval in Execution Dec 7, 2021
@PatelUtkarsh PatelUtkarsh moved this from Approval to Done in Execution Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
5 participants