Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card collection updates #211

Merged
merged 16 commits into from
Oct 5, 2021
Merged

Conversation

emeaguiar
Copy link
Collaborator

Summary

Fixes #61

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

@coveralls
Copy link

coveralls commented Sep 24, 2021

Pull Request Test Coverage Report for Build 1270631234

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 7 (57.14%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.4%) to 79.594%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/assets/src/block-editor/blocks/cards-collection/deprecated.js 2 3 66.67%
plugin/assets/src/block-editor/blocks/cards-collection/edit.js 0 2 0.0%
Totals Coverage Status
Change from base Build 1246737788: 1.4%
Covered Lines: 4586
Relevant Lines: 5601

💛 - Coveralls

Copy link
Collaborator

@PatelUtkarsh PatelUtkarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! @emeaguiar Left one suggestion.

},
{
label: __( 'Filled', 'material-design' ),
value: 'filled',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of filled, Should we say elevated as per material specs? https://material.io/components/cards

Copy link
Collaborator

@PatelUtkarsh PatelUtkarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emeaguiar emeaguiar merged commit 20886ed into develop Oct 5, 2021
@emeaguiar emeaguiar deleted the feature/61-card-collection-updates branch October 5, 2021 15:36
@emeaguiar emeaguiar mentioned this pull request Oct 5, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Settings for Card Collections Block
3 participants