Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/40 cta #108

Merged
merged 3 commits into from
Apr 26, 2021
Merged

Feature/40 cta #108

merged 3 commits into from
Apr 26, 2021

Conversation

ravichdev
Copy link
Contributor

Summary

Fixes #40

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

@coveralls
Copy link

coveralls commented Apr 23, 2021

Pull Request Test Coverage Report for Build 777936720

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 83.046%

Files with Coverage Reduction New Missed Lines %
plugin/assets/src/block-editor/blocks/list/components/list-item.js 1 85.71%
Totals Coverage Status
Change from base Build 770619474: -0.02%
Covered Lines: 4161
Relevant Lines: 4919

💛 - Coveralls

Copy link
Collaborator

@PatelUtkarsh PatelUtkarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ravichdev ravichdev merged commit 09ac073 into develop Apr 26, 2021
@ravichdev ravichdev deleted the feature/40-cta branch April 26, 2021 17:44
PatelUtkarsh pushed a commit that referenced this pull request Jun 5, 2021
PatelUtkarsh pushed a commit that referenced this pull request Jun 5, 2021
PatelUtkarsh pushed a commit that referenced this pull request Jun 6, 2021
PatelUtkarsh pushed a commit that referenced this pull request Jun 6, 2021
PatelUtkarsh added a commit that referenced this pull request Jun 8, 2021
PatelUtkarsh added a commit that referenced this pull request Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pattern] CTA + Benefits
3 participants