Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't remove image from card #22

Merged
merged 2 commits into from
Apr 3, 2021
Merged

Conversation

ravichdev
Copy link
Contributor

Summary

Fixes #16

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

@ravichdev ravichdev requested a review from emeaguiar April 1, 2021 18:30
@coveralls
Copy link

coveralls commented Apr 1, 2021

Pull Request Test Coverage Report for Build 709462925

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 85.247%

Totals Coverage Status
Change from base Build 687484382: 0.06%
Covered Lines: 3879
Relevant Lines: 4435

💛 - Coveralls

Copy link
Collaborator

@emeaguiar emeaguiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@coveralls
Copy link

coveralls commented Apr 2, 2021

Pull Request Test Coverage Report for Build 709462925

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 85.247%

Totals Coverage Status
Change from base Build 687484382: 0.06%
Covered Lines: 3879
Relevant Lines: 4435

💛 - Coveralls

@ravichdev ravichdev merged commit 5e87899 into develop Apr 3, 2021
@ravichdev ravichdev deleted the fix/564-card-image-remove branch April 3, 2021 06:35
ravichdev added a commit that referenced this pull request Apr 13, 2021
rodydavis pushed a commit that referenced this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't remove image from card
3 participants