Add FSE opt-in in customizer #307
Conversation
- Handle customizer preview for opt in or out from fse. - Load frontend template based on user preference. - Remove site editor menu by forcing index.html template to disabled.
| chunk: 'settings', | ||
| entry: [ | ||
| './plugin/assets/src/settings/index.js', | ||
| './plugin/assets/css/src/settings.css', |
There was a problem hiding this comment.
@emeaguiar Here theme is referencing to plugin asset - since we are adding setting page in theme as well.
| margin-left: auto; | ||
| margin-right: auto; | ||
| margin-left: auto !important; | ||
| margin-right: auto !important; |
There was a problem hiding this comment.
Unrelated: For non FSE it doesn't align center properly when only theme is active.
|
|
||
| if ( firstElement ) { | ||
| firstElement.setAttribute( 'tabindex', 0 ); | ||
| if ( drawerElement ) { |
There was a problem hiding this comment.
Unrelated: Fixes error in some edge case.
| return updateFonts(); | ||
| } | ||
|
|
||
| if ( type === UPDATERS.ICONS.type ) { | ||
| if ( type === ASSET_UPDATES.ICONS.type ) { |
There was a problem hiding this comment.
Changed reference since now UPDATERS defines object based on global variable and for tests, it fails as it gets empty so using ASSET_UPDATES which UPDATERS uses conditionally.
|
Hello @emeaguiar, This is ready for another review. For FSE Opt in now it uses setting page from plugin, If plugin is not active then theme registers setting page and enqueue required assets for settings. Currently, setting component is shared between plugin and theme both and lives in plugin. |
There was a problem hiding this comment.
@PatelUtkarsh I just have one suggestion about the settings page. Everything else is great!
|
|
||
| const checked = state.updaters.OPT_IN.autoUpdates; | ||
|
|
||
| const handleAutoUpdateToggle = () => { |
There was a problem hiding this comment.
Should we force a refresh here? I noticed the menus to the site editor either don't appear or remain visible when toggling this, so if I toggle it off and then go to the editor we get an error screen, until we refresh the page
There was a problem hiding this comment.
Good catch! Updated in 16d33c4
Summary
Fixes #255
Todo:
Demo:
Customizer
fse-opt-in.mp4
Admin notice
notice-updated.mp4
Checklist