Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/13 settings page #32

Closed
wants to merge 3 commits into from
Closed

Conversation

emeaguiar
Copy link
Collaborator

Summary

Fixes #

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

@emeaguiar emeaguiar requested a review from ravichdev April 7, 2021 14:23
@google-cla
Copy link

google-cla bot commented Apr 7, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@coveralls
Copy link

coveralls commented Apr 7, 2021

Pull Request Test Coverage Report for Build 726304350

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 58 of 147 (39.46%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.1%) to 84.012%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/assets/src/common/components/dialog/index.js 8 9 88.89%
plugin/php/updates/class-update-icons.php 4 5 80.0%
plugin/php/updates/class-updates-api-base.php 4 5 80.0%
plugin/php/updates/class-update-fonts.php 5 10 50.0%
plugin/php/class-admin.php 11 44 25.0%
plugin/php/rest/class-design-assets-rest-controller.php 24 72 33.33%
Totals Coverage Status
Change from base Build 723030875: -1.1%
Covered Lines: 4036
Relevant Lines: 4712

💛 - Coveralls

@ravichdev ravichdev closed this Apr 7, 2021
@ravichdev ravichdev deleted the feature/13-settings-page branch April 7, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants