Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query loop for image card and material card #353

Merged
merged 11 commits into from
May 17, 2022

Conversation

PatelUtkarsh
Copy link
Collaborator

@PatelUtkarsh PatelUtkarsh commented May 3, 2022

Summary

  • Ported code from FSE - Added WP version checks and styles.
  • Review commits from 6ce62c1

Fixes #338

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

@PatelUtkarsh
Copy link
Collaborator Author

Failing php test with trunk is fixed in af609be

@coveralls
Copy link

coveralls commented May 3, 2022

@PatelUtkarsh PatelUtkarsh marked this pull request as ready for review May 4, 2022 14:02
emeaguiar
emeaguiar previously approved these changes May 17, 2022
@emeaguiar emeaguiar merged commit 9ee8439 into develop May 17, 2022
@emeaguiar emeaguiar deleted the add/query-loop-pagination branch May 17, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add image card and material card with pattern for non FSE
3 participants