Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3 Card #387

Merged
merged 17 commits into from
Jul 25, 2022
Merged

M3 Card #387

merged 17 commits into from
Jul 25, 2022

Conversation

PatelUtkarsh
Copy link
Collaborator

@PatelUtkarsh PatelUtkarsh commented Jul 19, 2022

Summary

Todo:

  • Shadow style
  • Migration for card

Fixes #330

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

@PatelUtkarsh PatelUtkarsh marked this pull request as ready for review July 22, 2022 09:59
@coveralls
Copy link

coveralls commented Jul 22, 2022

Pull Request Test Coverage Report for Build 2717731049

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 43 of 78 (55.13%) changed or added relevant lines in 22 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on m3/card at 74.251%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/assets/src/block-editor/blocks/cards-collection/deprecation/m2/card-supporting-text.js 2 3 66.67%
plugin/assets/src/block-editor/blocks/cards-collection/deprecation/m2/vertical-card-layout.js 6 7 85.71%
plugin/php/blocks/class-card-block.php 0 1 0.0%
plugin/php/customizer/class-controls.php 3 4 75.0%
plugin/assets/src/block-editor/blocks/cards-collection/deprecation/m2/card-primary.js 2 4 50.0%
plugin/assets/src/block-editor/blocks/cards-collection/deprecation/m2/card-action-button.js 3 6 50.0%
plugin/php/template-parts/blocks/card-query.php 0 3 0.0%
plugin/assets/src/block-editor/blocks/cards-collection/deprecation/m2/cards.js 1 5 20.0%
plugin/php/class-helpers.php 0 4 0.0%
plugin/assets/src/block-editor/blocks/cards-collection/deprecation/m2/horizontal-card-layout.js 1 8 12.5%
Totals Coverage Status
Change from base Build 2699132480: 74.3%
Covered Lines: 4638
Relevant Lines: 6165

💛 - Coveralls

@emeaguiar emeaguiar merged commit ea54fea into develop Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[M3] Components - Material Card
3 participants