Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dark mode to plugin; init dark mode early #445

Merged
merged 4 commits into from
Sep 1, 2022
Merged

Conversation

PatelUtkarsh
Copy link
Collaborator

Summary

Dark mode code uses localize variable from plugin.

Fixes #443

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

@PatelUtkarsh PatelUtkarsh marked this pull request as ready for review September 1, 2022 12:55
@coveralls
Copy link

coveralls commented Sep 1, 2022

Pull Request Test Coverage Report for Build 2972883223

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 70.171%

Totals Coverage Status
Change from base Build 2972412054: -0.6%
Covered Lines: 4663
Relevant Lines: 6493

💛 - Coveralls

@emeaguiar emeaguiar merged commit 313228f into develop Sep 1, 2022
@emeaguiar emeaguiar deleted the fix/443 branch September 1, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode causes flash of color change
3 participants