Skip to content

Commit

Permalink
fix(menu): declare popover property type on HTMLElement
Browse files Browse the repository at this point in the history
Without it the popover property got renamed by closure.

PiperOrigin-RevId: 584184281
  • Loading branch information
material-web-copybara authored and Copybara-Service committed Nov 21, 2023
1 parent 8eb1f30 commit 3d8c7ac
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion menu/internal/controllers/surfacePositionController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {ReactiveController, ReactiveControllerHost} from 'lit';
import {StyleInfo} from 'lit/directives/style-map.js';

/**
* Declare popoverAPI functions. See
* Declare popoverAPI functions and properties. See
* https://developer.mozilla.org/en-US/docs/Web/API/Popover_API
* Without this, closure will rename these functions. Can remove once these
* functions make it into the typescript lib.
Expand All @@ -18,6 +18,7 @@ declare global {
showPopover(): void;
hidePopover(): void;
togglePopover(force: boolean): void;
popover: string | null;
}
}

Expand Down

0 comments on commit 3d8c7ac

Please sign in to comment.