fix(dialog)!: remove fullscreen tokens

PiperOrigin-RevId: 551964075
material-components · Jul 28, 2023 · 8b896e0 · 8b896e0
1 parent b1259ae
commit 8b896e0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 25 deletions.
diff --git a/dialog/internal/_dialog.scss b/dialog/internal/_dialog.scss
@@ -327,8 +327,9 @@
   :host([showing-fullscreen]) .header {
     justify-content: space-between;
     flex-direction: row;
-    max-block-size: var(--_fullscreen-header-block-size);
-    padding-block-start: var(--_fullscreen-container-block-padding);
+    max-block-size: 56px;
+    // Note, the 8px here is not per spec, but needed to make the explicit 56px not be cramped.
+    padding-block-start: 8px;
     // TODO: should there be explicit tokens for these?
     padding-inline: 4px;
     --_header-spacing: 4px;
@@ -340,8 +341,9 @@
   }
 
   :host([showing-fullscreen]) .footer {
-    max-block-size: var(--_fullscreen-footer-block-size);
-    padding-block-end: var(--_fullscreen-container-block-padding);
+    max-block-size: 56px;
+    // Note, the 8px here is not per spec, but needed to make the explicit 56px not be cramped.
+    padding-block-end: 8px;
   }
 
   // Hide bottom divider on fullscreen since it's common not to have footer actions.

diff --git a/dialog/internal/_tokens.scss b/dialog/internal/_tokens.scss
@@ -50,17 +50,7 @@ $_tokens: (
   with-divider-divider-color: map.get($_md-sys-color, 'outline')
 );
 
-$_fullscreen-tokens: (
-  fullscreen-header-block-size: 56px,
-  fullscreen-footer-block-size: 56px,
-  // Note, the 8px here is not per spec, but needed to make the explicit 56px not be cramped.
-  fullscreen-container-block-padding: 8px,
-);
-
 // Extended token set for dialog.
 @function md-comp-dialog-values() {
-  @return map.merge(
-    map.merge(tokens.md-comp-dialog-values(), $_tokens),
-    $_fullscreen-tokens
-  );
+  @return map.merge(tokens.md-comp-dialog-values(), $_tokens);
 }
diff --git a/dialog/internal/dialog.ts b/dialog/internal/dialog.ts
@@ -70,16 +70,6 @@ export class Dialog extends LitElement {
    * When showing fullscreen, the header will take up less vertical space, and
    * the dialog will have a `showing-fullscreen`attribute, allowing content to
    * be styled in this state.
-   *
-   * Dialogs can be sized by setting:
-   *
-   * * --md-dialog-container-min-block-size
-   * * --md-dialog-container-max-block-size
-   * * --md-dialog-container-min-inline-size
-   * * --md-dialog-container-max-inline-size
-   *
-   * These are typically configured via media queries and are independent of the
-   * fullscreen setting.
    */
   @property({type: Boolean}) fullscreen = false;