fix(iconbutton): make target type stricter

PiperOrigin-RevId: 557643977
material-components · Aug 16, 2023 · c874cd5 · c874cd5
1 parent d665864
commit c874cd5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/iconbutton/demo/demo.ts b/iconbutton/demo/demo.ts
@@ -18,7 +18,7 @@ const collection =
       new Knob('ariaLabel', {ui: textInput(), defaultValue: ''}),
       new Knob(
           'href', {ui: textInput(), defaultValue: 'https://www.google.com'}),
-      new Knob('target', {
+      new Knob<'_blank'|'_self', 'target'>('target', {
         ui: radioSelector({
           options: [
             {value: '_blank', label: '_blank'}, {value: '_self', label: '_self'}

diff --git a/iconbutton/demo/stories.ts b/iconbutton/demo/stories.ts
@@ -20,7 +20,7 @@ export interface StoryKnobs {
   icon: string;
   ariaLabel: string;
   href: string;
-  target: string;
+  target: '_blank'|'_parent'|'_self'|'_top'|'';
   selectedIcon: string;
   selectedAriaLabel: string;
   selected: boolean;

diff --git a/iconbutton/internal/icon-button.ts b/iconbutton/internal/icon-button.ts
@@ -55,7 +55,7 @@ export class IconButton extends LitElement implements FormSubmitter {
   /**
    * Sets the underlying `HTMLAnchorElement`'s `target` attribute.
    */
-  @property() target = '';
+  @property() target: LinkTarget|'' = '';
 
   /**
    * The `aria-label` of the button when the button is toggleable and selected.
@@ -130,7 +130,7 @@ export class IconButton extends LitElement implements FormSubmitter {
       <a class="link"
         id="link"
         href="${this.href}"
-        target="${this.target as LinkTarget || nothing}"
+        target="${this.target || nothing}"
         aria-label="${ariaLabel || nothing}"
       ></a>
     `;