Skip to content

Commit

Permalink
fix(radio)!: remove "unselected" prefix from tokens
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Rename `--md-radio-unselected-<token>` to `--md-radio-<token>`

PiperOrigin-RevId: 550907524
  • Loading branch information
AndrewJakubowicz authored and Copybara-Service committed Jul 25, 2023
1 parent f7b3ef7 commit fb1c603
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 21 deletions.
16 changes: 8 additions & 8 deletions radio/internal/_radio.scss
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ $_md-sys-motion: tokens.md-sys-motion-values();

@include ripple.theme(
(
hover-color: var(--_unselected-hover-state-layer-color),
hover-opacity: var(--_unselected-hover-state-layer-opacity),
pressed-color: var(--_unselected-pressed-state-layer-color),
pressed-opacity: var(--_unselected-pressed-state-layer-opacity),
hover-color: var(--_hover-state-layer-color),
hover-opacity: var(--_hover-state-layer-opacity),
pressed-color: var(--_pressed-state-layer-color),
pressed-opacity: var(--_pressed-state-layer-opacity),
)
);

Expand Down Expand Up @@ -94,7 +94,7 @@ $_md-sys-motion: tokens.md-sys-motion-values();
}

.icon {
fill: var(--_unselected-icon-color);
fill: var(--_icon-color);
height: var(--_icon-size);
width: var(--_icon-size);
}
Expand Down Expand Up @@ -136,15 +136,15 @@ $_md-sys-motion: tokens.md-sys-motion-values();
}

:host(:hover) .icon {
fill: var(--_unselected-hover-icon-color);
fill: var(--_hover-icon-color);
}

:host(:focus-within) .icon {
fill: var(--_unselected-focus-icon-color);
fill: var(--_focus-icon-color);
}

:host(:active) .icon {
fill: var(--_unselected-pressed-icon-color);
fill: var(--_pressed-icon-color);
}

:host([disabled]) .icon {
Expand Down
8 changes: 4 additions & 4 deletions radio/internal/forced-colors-styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@
selected-hover-icon-color: CanvasText,
selected-focus-icon-color: CanvasText,
selected-pressed-icon-color: CanvasText,
unselected-icon-color: CanvasText,
unselected-hover-icon-color: CanvasText,
unselected-focus-icon-color: CanvasText,
unselected-pressed-icon-color: CanvasText,
icon-color: CanvasText,
hover-icon-color: CanvasText,
focus-icon-color: CanvasText,
pressed-icon-color: CanvasText,
)
);
}
Expand Down
29 changes: 20 additions & 9 deletions tokens/_md-comp-radio-button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,15 @@ $supported-tokens: (
'disabled-selected-icon-opacity',
'disabled-unselected-icon-color',
'disabled-unselected-icon-opacity',
'focus-icon-color',
'hover-icon-color',
'hover-state-layer-color',
'hover-state-layer-opacity',
'icon-color',
'icon-size',
'pressed-icon-color',
'pressed-state-layer-color',
'pressed-state-layer-opacity',
'selected-focus-icon-color',
'selected-hover-icon-color',
'selected-hover-state-layer-color',
Expand All @@ -26,14 +34,6 @@ $supported-tokens: (
'selected-pressed-state-layer-color',
'selected-pressed-state-layer-opacity',
'state-layer-size',
'unselected-focus-icon-color',
'unselected-hover-icon-color',
'unselected-hover-state-layer-color',
'unselected-hover-state-layer-opacity',
'unselected-icon-color',
'unselected-pressed-icon-color',
'unselected-pressed-state-layer-color',
'unselected-pressed-state-layer-opacity',
// go/keep-sorted end
);

Expand All @@ -55,7 +55,18 @@ $_default: (
$tokens: values.validate(
md-comp-radio-button.values($deps, $exclude-hardcoded-values),
$supported-tokens: $supported-tokens,
$unsupported-tokens: $unsupported-tokens
$unsupported-tokens: $unsupported-tokens,
$renamed-tokens: (
// Remove default "unselected" prefix (b/292244480)
'unselected-focus-icon-color': 'focus-icon-color',
'unselected-hover-icon-color': 'hover-icon-color',
'unselected-hover-state-layer-color': 'hover-state-layer-color',
'unselected-hover-state-layer-opacity': 'hover-state-layer-opacity',
'unselected-icon-color': 'icon-color',
'unselected-pressed-icon-color': 'pressed-icon-color',
'unselected-pressed-state-layer-color': 'pressed-state-layer-color',
'unselected-pressed-state-layer-opacity': 'pressed-state-layer-opacity'
)
);

@return $tokens;
Expand Down

0 comments on commit fb1c603

Please sign in to comment.