Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing required property on the radio component. #4316

Closed
MrHBS opened this issue May 22, 2023 · 3 comments · Fixed by #5094 · May be fixed by X-oss-byte/pigweed#61
Closed

Missing required property on the radio component. #4316

MrHBS opened this issue May 22, 2023 · 3 comments · Fixed by #5094 · May be fixed by X-oss-byte/pigweed#61
Assignees

Comments

@MrHBS
Copy link
Contributor

MrHBS commented May 22, 2023

Missing required property on the checkbox and radio components. Also the switch component could use aria-required (and aria-readonly/disabled?) I think?

@MrHBS MrHBS changed the title Missing required and readonly properties on the checkbox and radio components. Missing required property on the checkbox and radio components. May 22, 2023
@christophe-g
Copy link
Contributor

While at this, aria-controls would also be very usefull for checkbox.

I can propose a PR if we agree on its scope.

@asyncLiz
Copy link
Collaborator

At the moment IDREF aria properties such as aria-controls or aria-labelledby aren't well supported with shadow dom, so I don't think those will be easy features.

Adding required to checkbox and radio groups along with validity seem like a reasonable feature.

@asyncLiz asyncLiz self-assigned this Aug 23, 2023
@asyncLiz asyncLiz changed the title Missing required property on the checkbox and radio components. Missing required property on the radio component. Sep 11, 2023
@asyncLiz
Copy link
Collaborator

Checkbox has required now, radio is still missing it

copybara-service bot pushed a commit that referenced this issue Nov 27, 2023
Fixes #4316

PiperOrigin-RevId: 585713253
copybara-service bot pushed a commit that referenced this issue Nov 27, 2023
Fixes #4316

PiperOrigin-RevId: 585713253
copybara-service bot pushed a commit that referenced this issue Nov 27, 2023
Fixes #4316

PiperOrigin-RevId: 585713253
copybara-service bot pushed a commit that referenced this issue Nov 28, 2023
Fixes #4316

PiperOrigin-RevId: 585713253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment