Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

md-select default cursor #5066

Closed
kkachniarz220 opened this issue Oct 9, 2023 · 1 comment · Fixed by #5069 or #5005 · May be fixed by X-oss-byte/pigweed#61
Closed

md-select default cursor #5066

kkachniarz220 opened this issue Oct 9, 2023 · 1 comment · Fixed by #5069 or #5005 · May be fixed by X-oss-byte/pigweed#61
Assignees
@e111077

Comments

@kkachniarz220
Copy link
Contributor

What is affected?

Component

Description

Select component should have pointer cursor.

Reproduction

Not applicable

Workaround

Not applicable

Is this a regression?

No or unsure. This never worked, or I haven't tried before.

Affected versions

1.0.0

Browser/OS/Node environment

Chrome 117.0.5938.150
Windows 11
@kkachniarz220 kkachniarz220 changed the title Select default cursor Select component default cursor Oct 9, 2023
@kkachniarz220 kkachniarz220 changed the title Select component default cursor md-select default cursor Oct 9, 2023
@e111077
Copy link
Member

e111077 commented Oct 10, 2023 •
edited

You are correct here, the guidance seems to show a pointer:

https://m3.material.io/components/menus/guidelines#73531839-5ef8-46cd-9a5e-223f32912edb

update: clarification that the guidelines show the items to be cursor: pointer, but not necessarily the host. And it seems that native <select> keeps the cursor on default so I don't think that should be changed

@e111077 e111077 self-assigned this Oct 10, 2023
copybara-service bot pushed a commit that referenced this issue Oct 10, 2023
@e111077
fix(select): cursor on select options should be pointer
5ef8b64 
per: https://m3.material.io/components/menus/guidelines#73531839-5ef8-46cd-9a5e-223f32912edb

fixes #5066

PiperOrigin-RevId: 572159265
@copybara-service copybara-service bot mentioned this issue Oct 10, 2023
Merged
copybara-service bot pushed a commit that referenced this issue Oct 10, 2023
@e111077
fix(select): cursor on select options should be pointer
6a08da3 
per: https://m3.material.io/components/menus/guidelines#73531839-5ef8-46cd-9a5e-223f32912edb

fixes #5066

PiperOrigin-RevId: 572159265
copybara-service bot pushed a commit that referenced this issue Oct 10, 2023
@e111077
fix(select): cursor on select options should be pointer
0579d25 
per: https://m3.material.io/components/menus/guidelines#73531839-5ef8-46cd-9a5e-223f32912edb

fixes #5066

PiperOrigin-RevId: 572159265
@release-please release-please bot mentioned this issue Oct 10, 2023
Merged
copybara-service bot pushed a commit that referenced this issue Oct 17, 2023
@e111077
refactor(checkbox): move cursor styles to host
08d1061 
related: #5066 #5069
PiperOrigin-RevId: 574300108
@copybara-service copybara-service bot mentioned this issue Oct 17, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Oct 17, 2023
@e111077
refactor(checkbox): move cursor styles to host
f726c69 
related: #5066 #5069
PiperOrigin-RevId: 574300108
copybara-service bot pushed a commit that referenced this issue Oct 17, 2023
@e111077
refactor(checkbox): move cursor styles to host
06909e5 
related: #5066 #5069
PiperOrigin-RevId: 574302352
@X-oss-byte X-oss-byte mentioned this issue May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e111077 e111077

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@e111077 @kkachniarz220