Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ripple Start Position on Touch Event #5349

Closed
Kamilko16 opened this issue Dec 27, 2023 · 2 comments · Fixed by #5367 or #5295 · May be fixed by X-oss-byte/pigweed#61
Closed

Ripple Start Position on Touch Event #5349

Kamilko16 opened this issue Dec 27, 2023 · 2 comments · Fixed by #5367 or #5295 · May be fixed by X-oss-byte/pigweed#61
Assignees
@asyncLiz

Comments

@Kamilko16
Copy link

What is affected?

Component

Description

When the button is touched, only the first touch ripple start position is correct (it starts in touch position). Next touches have start position exactly in the middle of the button, no matter where touched.

Reproduction

Touch the button two or more times, spot the difference. Refreshing page resets the problem.

Workaround

I haven't found workaround.

Is this a regression?

No or unsure. This never worked, or I haven't tried before.

Affected versions

1.1.1

Browser/OS/Node environment

Browser: Chrome 120.0.6099.111 on desktop, Chrome 120.0.6099.116 on mobile.
node: v20.9.0
@asyncLiz
Copy link
Collaborator

Which platforms have the problem (iOS, Android, Mac OS/Windows/ChromeOS with touchscreen)? Both desktop and mobile please :)

@Kamilko16
Copy link
Author

I only tested it on Windows (mouse works fine, only phone emulation has this problem) and Android also has this problem. The problem is with the ripple compontent itself i think.

@asyncLiz asyncLiz self-assigned this Dec 27, 2023
copybara-service bot pushed a commit that referenced this issue Jan 5, 2024
@asyncLiz
fix(ripple): multiple touches causing ripples to start from center
44f0131 
Fix is pretty simple, we weren't clearing out the first pointerdown event, and subsequent ones were ignored since the `pointerId` changes with each touch.

Fixes #5349

PiperOrigin-RevId: 596047639
@copybara-service copybara-service bot mentioned this issue Jan 5, 2024
Merged
copybara-service bot pushed a commit that referenced this issue Jan 5, 2024
@asyncLiz
fix(ripple): multiple touches causing ripples to start from center
060633e 
Fix is pretty simple, we weren't clearing out the first pointerdown event, and subsequent ones were ignored since the `pointerId` changes with each touch.

Fixes #5349

PiperOrigin-RevId: 596047639
copybara-service bot pushed a commit that referenced this issue Jan 5, 2024
@asyncLiz
fix(ripple): multiple touches causing ripples to start from center
cb658b4 
Fix is pretty simple, we weren't clearing out the first pointerdown event, and subsequent ones were ignored since the `pointerId` changes with each touch.

Fixes #5349

PiperOrigin-RevId: 596047639
@asyncLiz asyncLiz mentioned this issue Jan 8, 2024
Closed
copybara-service bot pushed a commit that referenced this issue Jan 8, 2024
@asyncLiz
fix(ripple): multiple touches causing ripples to start from center
34115f6 
Fix is pretty simple, we weren't clearing out the first pointerdown event, and subsequent ones were ignored since the `pointerId` changes with each touch.

Fixes #5349

PiperOrigin-RevId: 596047639
@release-please release-please bot mentioned this issue Jan 8, 2024
Merged
@X-oss-byte X-oss-byte mentioned this issue May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asyncLiz asyncLiz

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Kamilko16 @asyncLiz