-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ESM "module" entrypoint #434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @FredKSchott! LGTM, thanks for the PR!
Actually a question. It looks like rollup-plugin-node-resolve already falls back to |
Also, what about |
A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM2
👋 hey y’all! Great to see so many familiar faces. @kenchris tagged me in here from twitter. I’d have to find it, but the official Node guidance is to not publish anything with “type”:”module” yet until it’s officially out from behind the flag. But their main concern is node breakage, so 🤷♂️. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approval train 🚂
This lets tools like pika.dev detect that your package is written as an ES Module and not Common.js. See https://github.com/rollup/rollup/wiki/pkg.module for more info