Fix dependency references and tests. #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bicknellr
commented
May 23, 2018
| @@ -41,11 +41,12 @@ test('element._formElement returns the native checkbox element', () => { | |||
| assert.equal(element._formElement.localName, 'input'); | |||
| }); | |||
|
|
|||
| test('element._component returns the mdc checkbox component', () => { | |||
| test('element._component returns the mdc checkbox component', async () => { | |||
| await element.componentReady(); | |||
There was a problem hiding this comment.
This is the only functional change - I'm not sure if it's correct but other tests seemed to do this before reading ._component and adding it here caused this test to stop failing.
dfreedm
approved these changes
May 29, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mwc-fabis now in its own package.mwc-ripple-surfacedoesn't seem to exist as a separate component anymore.asyncto a few test functions that were usingawait.There are still some left over uncaught errors that happen when running the tests that I'm still looking into. They don't cause the tests to fail though, so they must be async.