Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Drizzle ORM #2127

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

UsamaKhan
Copy link
Contributor

@UsamaKhan UsamaKhan commented Nov 3, 2023

Added icon and file icons for Drizzle ORM.

Closes: #2105

Copy link

github-actions bot commented Apr 17, 2024

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated preview

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@jamiehaywood
Copy link
Contributor

any update on this one?

@UsamaKhan
Copy link
Contributor Author

@PKief please let me know if/when this can be merged. I've also updated the file icon to work better in light themes based on drizzle's own colors:
image
image

Copy link
Member

@lucas-labs lucas-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shape of the folder icon has changed slightly since you opened this PR.
See the suggested changes :)

icons/folder-drizzle-open.svg Outdated Show resolved Hide resolved
icons/folder-drizzle.svg Outdated Show resolved Hide resolved
Co-authored-by: Lucas Colombo <lucasncolombo@gmail.com>
@material-extensions material-extensions deleted a comment from github-actions bot Jul 19, 2024
@material-extensions material-extensions deleted a comment from github-actions bot Jul 19, 2024
@material-extensions material-extensions deleted a comment from github-actions bot Jul 19, 2024
@material-extensions material-extensions deleted a comment from github-actions bot Jul 19, 2024
@lucas-labs
Copy link
Member

lucas-labs commented Jul 19, 2024

Hi there, I just updated the branch with the latest changes in the main branch and:

  • fixed failing CI (black color not allowed error)
  • fixed the file icon assignment from fileExtension to fileName (let me know if this is ok, I haven't used drizzle since a long time but after reading their docs it seems that fileExtension assignments were incorrect)
  • removed the light version of the file icon and changed the colors of the icons so that we can use the same version in both light and dark themes instead. I think the original green from the drizzle logo is nice, but it's too bright, saturated and constrasty compared to the other icons of the theme. Also... one less file. But hey, that's my opinion, so let me know.
  • Changed the shapes a bit so that they feel less blurry when rendered at 16x16 pixels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request] <drizzleORM>
3 participants