-
-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(filenames): add patterns support #2289
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f45333
to
a245001
Compare
Airkro
commented
Apr 22, 2024
a245001
to
28ec90a
Compare
Now only 4 patterns are left behind, they are used frequently, input Ecmascript:
- xyz123.js
- xyz123.mjs
- xyz123.cjs
- xyz123.ts
- xyz123.mts
- xyz123.cts
Configuration:
- xyz123.json
- xyz123.jsonc
- xyz123.json5
- xyz123.yaml
- xyz123.yml
- xyz123.toml
NodeEcosystem:
- xyz123.json
- xyz123.jsonc
- xyz123.json5
- xyz123.yaml
- xyz123.yml
- xyz123.toml
- xyz123.js
- xyz123.mjs
- xyz123.cjs
- xyz123.ts
- xyz123.mts
- xyz123.cts
Cosmiconfig:
- .xyz123rc
- .xyz123rc.json
- .xyz123rc.jsonc
- .xyz123rc.json5
- .xyz123rc.yaml
- .xyz123rc.yml
- .xyz123rc.toml
- .xyz123rc.js
- .xyz123rc.mjs
- .xyz123rc.cjs
- .xyz123rc.ts
- .xyz123rc.mts
- .xyz123rc.cts
- .config/xyz123rc
- .config/xyz123rc.json
- .config/xyz123rc.jsonc
- .config/xyz123rc.json5
- .config/xyz123rc.yaml
- .config/xyz123rc.yml
- .config/xyz123rc.toml
- .config/xyz123rc.js
- .config/xyz123rc.mjs
- .config/xyz123rc.cjs
- .config/xyz123rc.ts
- .config/xyz123rc.mts
- .config/xyz123rc.cts
- xyz123.config.json
- xyz123.config.jsonc
- xyz123.config.json5
- xyz123.config.yaml
- xyz123.config.yml
- xyz123.config.toml
- xyz123.config.js
- xyz123.config.mjs
- xyz123.config.cjs
- xyz123.config.ts
- xyz123.config.mts
- xyz123.config.cts |
Airkro
commented
Apr 22, 2024
2e2de75
to
2c8c5b2
Compare
PKief
approved these changes
Apr 22, 2024
PKief
added a commit
that referenced
this pull request
Apr 22, 2024
Merged with d6c1c09 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress
From: #2282 (comment)
Many popular tools, like eslint/stylelint/prettier/syncpack/postcss/babel/graphql/commitlint... use config loaders like cosmiconfig/lilconfig/unoconfig/rc-loader...
They all have a long filename list like this, For now, many of them are still not completing the list.
Currently, people help maintain these filenames by creating similar patterns and checking them line by line to identify which ones are missing. This process results in numerous pull requests.
I create some helper functions as built-in support? It will make the list shorter, and easy to maintain, and easy to send PR in the future.