-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new icons for files in .vscode
folder
#2335
Conversation
* feat: ⚙️ Refactor pattern code structure * Rename type * feat: update barrels * feat: update recommended extensions for development * Add comment
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
@PKief, I added icons for |
e748540
to
b209d61
Compare
eeb4f0e
to
b2e0fe4
Compare
2ff604a
to
b1ad1d2
Compare
Any updates? |
Why not target all the json files inside the vscode directory ? |
And what other files can there be? |
@okineadev it doesn't matter, what I suggested is that rather than define a custom icon for each of the files inside the .vscode folder, I'd have all these .json files use the same "vscode" icon. From a user's perspective, I don't think users will care if |
I'm already used to the json icons there. Is it worth it to give all of these files an icon? I don't see it at the moment |
Okay. |
Added icons for the following files:
.vscode/settings.json
.vscode/extensions.json
.vscode/launch.json
.vscode/settings.json