feat: Add CITATION.cff icon and update fileIcons
#2338
Conversation
* feat: ⚙️ Refactor pattern code structure * Rename type * feat: update barrels * feat: update recommended extensions for development * Add comment
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
Also fixing the centering of the icon
Anselmoo
force-pushed
the
Anselmoo/issue2337
branch
from
bb2d891
to
cb64b1e
Compare
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
|
PKief
force-pushed
the
main
branch
2 times, most recently
from
e748540
to
b209d61
Compare
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
There was a problem hiding this comment.
Thanks for the PR. This icon is not fitting into the theme, because it's hardly to read the letters "CFF" and typically I try to avoid using letters at all for the icons. In addition there's no space around it as mentioned in the contributing guidelines. So I doubt it that this icon can be merged to the main branch.
As we already have an icon for this file type, I think we should keep that:
There was a problem hiding this comment.
@PKief, thx for the quick feedback ...
One short question would be a material format-quote " a possibility?
It is just about the visibility of this unique type of file.
PKief
force-pushed
the
main
branch
2 times, most recently
from
eeb4f0e
to
b2e0fe4
Compare
PKief
force-pushed
the
main
branch
2 times, most recently
from
2ff604a
to
b1ad1d2
Compare
Description
Add
CITATION.cfficon for cff-files for GitHub repos, see also: https://citation-file-format.github.ioContribution Guidelines