Added Ansible icon #2344
Added Ansible icon #2344
Conversation
* feat: ⚙️ Refactor pattern code structure * Rename type * feat: update barrels * feat: update recommended extensions for development * Add comment
Change from `[ ]` to real checkbox ☑️
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
PKief
force-pushed
the
main
branch
2 times, most recently
from
e748540
to
b209d61
Compare
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
There was a problem hiding this comment.
I'd prefer it if you could avoid using "black" and "white" as colors. In addition, it would be better if the ansible icon could look like this one https://github.com/PKief/vscode-material-icon-theme/pull/1814/files#diff-b7f0f8081b9819ea3ff9d5b52984e117032e5b6e2f16e814c5cbcfc71d977d0d. So without that circle as background. And maybe even single colored? I mean, do we really need a dark and light one?
There was a problem hiding this comment.
ah and please always add some space around the icons:
https://github.com/PKief/vscode-material-icon-theme/blob/main/CONTRIBUTING.md#icon-spacing
There was a problem hiding this comment.
I think it is better to modify and accept PR #1814 :)
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
Closes #1669