-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add now icon for now.json
#470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, there's already another pull request for this kind of icon: #428
The problem of your suggested icon is the white color. Could you imagine how it looks like on a light theme with a bright background? I assure you, it'll be hard to recognize. The Material Icon Theme was implemented to support both light and dark backgrounds. This is why we should either provide an icon with a color that works for both themes or two icons, one for light and another for a dark background.
Hi, I have added the light version of the icon. |
It is ok if icons are purely white and black? |
@LukasPolak Thank you, I'll take a look. It's actually not a problem if multiple pull requests are created for the same icon. I just wanted to point out that there already existed another one ;) |
No description provided.