Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Icon] folder-error #490

Merged
merged 14 commits into from Jul 16, 2019
Merged

[New Icon] folder-error #490

merged 14 commits into from Jul 16, 2019

Conversation

lffg
Copy link
Contributor

@lffg lffg commented Jul 7, 2019 •
edited
Loading

New icon for error, errors and err folders.

new folder icons preview

@PKief PKief self-requested a review July 14, 2019 20:34
PKief
PKief approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slightly darkened the hue and changed the icon from outline to filled because I think it now fits better to the other icons of the extension:

updated error folder icon

However, thank you, you did a nice job 👍

@PKief PKief merged commit 34d8f46 into material-extensions:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lffg @PKief @omenos