Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icon Request] AdonisJs icon #658

Merged
merged 2 commits into from
Mar 30, 2020
Merged

[Icon Request] AdonisJs icon #658

merged 2 commits into from
Mar 30, 2020

Conversation

devcass
Copy link
Contributor

@devcass devcass commented Mar 4, 2020

No description provided.

@devcass devcass changed the title Add adonisjs icon to .adonisrc.json for adonisjs new version [Icon Request] AdonisJs icon Mar 4, 2020
@PKief PKief self-requested a review March 8, 2020 21:51
@PKief PKief self-assigned this Mar 30, 2020
PKief
PKief approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it looks good in general, I'll do some additional changes to the icon and I'll fix the "fileNames" issue. You did a good job, I'll take over the issue from here, so nothing else to do for you! Thank you!

src/icons/fileIcons.ts Show resolved Hide resolved
@PKief PKief merged commit 35d5fc2 into material-extensions:master Mar 30, 2020
PKief added a commit that referenced this pull request Mar 31, 2020
@PKief
Update Adonis file icon (References #658)
1034fd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief approved these changes

Assignees

@PKief PKief

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devcass @PKief